Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: Allow custom GOPROXY environment variable for buildlet #43839

Closed
oiooj opened this issue Jan 22, 2021 · 1 comment
Closed

x/build/cmd/coordinator: Allow custom GOPROXY environment variable for buildlet #43839

oiooj opened this issue Jan 22, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Backlog

Comments

@oiooj
Copy link
Member

oiooj commented Jan 22, 2021

Now only go repo won't overwrite GOPROXY env in coordinator, the default value is proxy.golang.org, But some builders in some countries cannot access this service, maybe we should allow custom GOPROXY environment variable in coordinator for builders.

builder error log when testing golang.org/x repos:

go: golang.org/x/sys@v0.0.0-20201119102817-f84b799fce68: Get "https://proxy.golang.org/golang.org/x/sys/@v/v0.0.0-20201119102817-f84b799fce68.mod": dial tcp 64.233.189.141:443: i/o timeout

Full log

@mengzhuo already mailed a CL 275412. If anything else need to be change, I'd like to push it.

/cc @bcmills @dmitshur
@oiooj oiooj added Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jan 22, 2021
@oiooj oiooj added this to the Backlog milestone Jan 22, 2021
@oiooj
Copy link
Member Author

oiooj commented Jan 22, 2021

Dup of #42971

@oiooj oiooj closed this as completed Jan 22, 2021
@golang golang locked and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@oiooj @gopherbot