Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.fuzz] cmd/go: default value of fuzzminimizetime flag is stated twice #46555

Closed
picatz opened this issue Jun 3, 2021 · 2 comments
Closed
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@picatz
Copy link

picatz commented Jun 3, 2021

馃憢 Hello! I am really excited about the native fuzzing beta, this is awesome!

I stumbled upon something fairly minor, but I figured I'd make an issue.

$ gotip version
go version devel go1.17-106851ad73 Wed Jun 2 22:39:15 2021 +0000 linux/amd64
$ gotip test -fuzz=FuzzParseQuery -bad-flag-to-trigger-usage-information             
...
  -test.fuzzminimizetime value
    	time to spend minimizing a value after finding a crash; default is to minimize for 60s (default 1m0s)
...

鈽濓笍 I would've expected it just to state (default 1m0s) like other flags with default values.

The flag usage is defined here:

flag.Var(&minimizeDuration, "test.fuzzminimizetime", "time to spend minimizing a value after finding a crash; default is to minimize for 60s")

With a default set here that seems to generate the (default 1m0s) portion:

minimizeDuration = durationOrCountFlag{d: 60 * time.Second}

@katiehockman
Copy link
Contributor

Thanks for filing this! We should fix that.

@katiehockman katiehockman added fuzz Issues related to native fuzzing support help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jun 4, 2021
@katiehockman katiehockman changed the title [dev.fuzz] Default value of fuzzminimizetime flag is stated twice [dev.fuzz] cmd/go: default value of fuzzminimizetime flag is stated twice Jun 4, 2021
@katiehockman katiehockman added this to the Unreleased milestone Jun 4, 2021
@gopherbot
Copy link

Change https://golang.org/cl/325070 mentions this issue: [dev.fuzz] testing: fix documentation for fuzzminimizetime

gopherbot pushed a commit that referenced this issue Jun 7, 2021
This removes redundancy for the default value.

Fixes #46555

Change-Id: Ib62bd2d584ef82bef806d0fe2ce59957488e469e
Reviewed-on: https://go-review.googlesource.com/c/go/+/325070
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
@golang golang locked and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: No status
Development

No branches or pull requests

3 participants