Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/vulndb/govulncheck: test fails when "unzip" is not in PATH #47314

Closed
bcmills opened this issue Jul 21, 2021 · 3 comments
Closed

x/exp/vulndb/govulncheck: test fails when "unzip" is not in PATH #47314

bcmills opened this issue Jul 21, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented Jul 21, 2021

golang.org/x/exp/vulndb/govulncheck is persistently failing on the longtest builders since CL 329809:

--- FAIL: TestKubernetes (7.89s)
    main_test.go:300: failed to build k8s: 
    main_test.go:301: exec: "unzip": executable file not found in $PATH
FAIL
FAIL	golang.org/x/exp/vulndb/govulncheck	40.964s

It probably needs a t.Skip if exec.LookPath("unzip") fails. (Compare golang.org/x/tools/internal/testenv.NeedsTool.)
@gopherbot gopherbot added this to the Unreleased milestone Jul 21, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Jul 21, 2021

(This is a release-blocker for Go 1.17 via #11811, but I don't expect that it will take much effort to fix.)

@bcmills bcmills added release-blocker NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. labels Jul 21, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.17 Jul 21, 2021
@gopherbot
Copy link

Change https://golang.org/cl/336309 mentions this issue: govulncheck: checks for dependencies in k8s integration testing

@zpavlinovic
Copy link
Contributor

I have created a small CL that should just make the failure go away. Will follow it up with a solution using standard libraries.

@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
@golang golang locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
Go1.17
Development

No branches or pull requests
5 participants
@zpavlinovic @FiloSottile @bcmills @julieqiu @gopherbot