Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/vulndb/govulncheck: test fails when "unzip" is not in PATH #47314

Closed
bcmills opened this issue Jul 21, 2021 · 3 comments
Closed

x/exp/vulndb/govulncheck: test fails when "unzip" is not in PATH #47314

bcmills opened this issue Jul 21, 2021 · 3 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jul 21, 2021

golang.org/x/exp/vulndb/govulncheck is persistently failing on the longtest builders since CL 329809:

--- FAIL: TestKubernetes (7.89s)
    main_test.go:300: failed to build k8s: 
    main_test.go:301: exec: "unzip": executable file not found in $PATH
FAIL
FAIL	golang.org/x/exp/vulndb/govulncheck	40.964s

It probably needs a t.Skip if exec.LookPath("unzip") fails. (Compare golang.org/x/tools/internal/testenv.NeedsTool.)

@gopherbot gopherbot added this to the Unreleased milestone Jul 21, 2021
@bcmills
Copy link
Member Author

@bcmills bcmills commented Jul 21, 2021

(This is a release-blocker for Go 1.17 via #11811, but I don't expect that it will take much effort to fix.)

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 21, 2021

Change https://golang.org/cl/336309 mentions this issue: govulncheck: checks for dependencies in k8s integration testing

@zpavlinovic
Copy link

@zpavlinovic zpavlinovic commented Jul 21, 2021

I have created a small CL that should just make the failure go away. Will follow it up with a solution using standard libraries.

@gopherbot gopherbot closed this in 6781d3e Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants