-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Description
Hi there,
@aalexand and I recently landed a change to github.com/google/pprof to add -tagroot and -tagleaf support for breaking down flamegraph profiles by pprof labels. I imagine this will be particularly useful for Go programs where labels are exposed in the runtime to users.
I'd like to request a pull of the latest github.com/google/pprof into https://github.com/golang/go/tree/master/src/cmd/vendor/github.com/google/pprof, to get this feature into the next Go release, so I can write up my blog post and tell people after the next Go version ships?
I see this was last updated 29 days ago with 9581d89, so perhaps I'm too late. It's OK if I have to wait till the next Go release (if there's a freeze or something), I just thought I'd open this issue in case you're excited about this getting this new profiling feature into the hands of users.