Skip to content

x/net/http2: failures in TestTransportRetriesOnStreamProtocolError starting 2021-10-04 #48994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Oct 14, 2021 · 5 comments
Closed

x/net/http2: failures in TestTransportRetriesOnStreamProtocolError starting 2021-10-04 #48994

bcmills opened this issue Oct 14, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 14, 2021

greplogs --dashboard -md -l -e 'FAIL: TestTransportRetriesOnStreamProtocolError'

2021-10-14T19:24:35-2b766c0-4cbc0a5/illumos-amd64
2021-10-14T18:44:48-2b766c0-0fd0639/windows-arm64-10
2021-10-14T17:25:44-2b766c0-fbdf830/linux-arm64-packet
2021-10-14T17:25:44-2b766c0-c580180/linux-ppc64le-buildlet
2021-10-14T04:18:44-e13a265-9e4dc6f/windows-arm64-10
2021-10-13T20:31:25-e13a265-b90d258/linux-ppc64-buildlet
2021-10-13T17:16:12-e13a265-4a3daee/illumos-amd64
2021-10-13T17:12:55-e13a265-c580180/android-386-emu
2021-10-13T16:36:59-ee2e9a0-69041c7/linux-ppc64le-buildlet
2021-10-13T15:36:59-ee2e9a0-f687831/linux-ppc64le-power9osu
2021-10-13T15:36:59-ee2e9a0-c580180/linux-ppc64le-power9osu
2021-10-13T15:36:59-ee2e9a0-2ac3bdf/linux-ppc64le-buildlet
2021-10-13T15:34:56-08712a7-c580180/android-amd64-emu
2021-10-13T15:12:46-caeb26a-f687831/linux-ppc64-buildlet
2021-10-13T00:11:47-caeb26a-4fb2e1c/illumos-amd64
2021-10-13T00:11:47-caeb26a-4fb2e1c/netbsd-arm-bsiegert
2021-10-12T22:26:55-caeb26a-78d01be/illumos-amd64
2021-10-12T22:26:55-caeb26a-78d01be/linux-ppc64-buildlet
2021-10-12T21:15:50-caeb26a-3d051ba/linux-ppc64-buildlet
2021-10-12T18:52:28-caeb26a-26b6833/illumos-amd64
2021-10-12T04:35:19-caeb26a-6372e7e/android-amd64-emu
2021-10-12T04:35:19-caeb26a-6372e7e/linux-ppc64le-buildlet
2021-10-11T17:04:08-caeb26a-c580180/illumos-amd64
2021-10-11T17:04:08-caeb26a-c580180/linux-ppc64le-buildlet
2021-10-11T17:04:08-caeb26a-577bb7d/linux-ppc64le-power9osu
2021-10-11T17:04:08-caeb26a-2ac3bdf/android-amd64-emu
2021-10-11T16:48:22-3b03d30-aa1c6f5/linux-ppc64-buildlet
2021-10-11T15:28:50-3b03d30-702e337/linux-ppc64-buildlet
2021-10-11T12:42:06-3b03d30-59b2f51/linux-mips64le-mengzhuo
2021-10-08T21:38:44-3b03d30-74abcab/windows-arm64-10
2021-10-08T19:48:52-3b03d30-c580180/linux-ppc64le-power9osu
2021-10-08T19:41:16-59d4e92-7fcf9a1/windows-arm64-10
2021-10-08T19:19:09-59d4e92-b9e1e1b/linux-ppc64-buildlet
2021-10-08T19:19:09-59d4e92-b9e1e1b/linux-ppc64le-buildlet
2021-10-08T19:19:09-59d4e92-b9e1e1b/windows-arm64-10
2021-10-08T18:07:25-59d4e92-d480b5c/android-386-emu
2021-10-08T15:27:20-59d4e92-b3a4b2d/linux-ppc64-buildlet
2021-10-08T14:08:12-59d4e92-5b9206f/linux-ppc64le-buildlet
2021-10-07T22:19:58-59d4e92-1ceb723/linux-ppc64le-power9osu
2021-10-07T19:49:45-59d4e92-c580180/linux-ppc64le-buildlet
2021-10-07T18:34:24-59d4e92-2043b3b/linux-ppc64le-power9osu
2021-10-07T18:11:41-59d4e92-2ac3bdf/illumos-amd64
2021-10-07T14:37:45-59d4e92-ebeab63/android-amd64-emu
2021-10-07T12:55:05-59d4e92-7d57324/linux-ppc64le-power9osu
2021-10-07T12:55:05-59d4e92-6f74ed0/illumos-amd64
2021-10-07T02:30:47-62292e8-39bbf08/android-386-emu
2021-10-07T02:30:47-62292e8-39bbf08/android-amd64-emu
2021-10-06T23:26:57-62292e8-c8dd89e/android-amd64-emu
2021-10-06T23:26:57-62292e8-c8dd89e/linux-ppc64le-power9osu
2021-10-06T23:19:13-62292e8-4707a6c/windows-arm64-10
2021-10-06T23:01:01-62292e8-4ffa2f1/linux-ppc64-buildlet
2021-10-06T22:28:59-62292e8-b18ba59/windows-arm64-10
2021-10-06T21:06:48-62292e8-197b328/android-386-emu
2021-10-06T20:30:12-62292e8-4a37a1d/linux-ppc64-buildlet
2021-10-06T20:21:49-62292e8-f580b75/linux-ppc64le-power9osu
2021-10-06T19:08:15-62292e8-6487b15/linux-ppc64-buildlet
2021-10-06T19:02:31-62292e8-195945a/linux-ppc64le-buildlet
2021-10-06T19:02:31-62292e8-04242ac/illumos-amd64
2021-10-06T16:46:09-d2e5035-3160571/linux-ppc64-buildlet
2021-10-06T00:43:45-d2e5035-72c52bf/linux-ppc64-buildlet
2021-10-05T23:36:43-d2e5035-e82ed0c/linux-ppc64le-buildlet
2021-10-05T22:42:11-d2e5035-96fface/illumos-amd64
2021-10-05T21:50:30-d2e5035-04242ac/illumos-amd64
2021-10-05T21:50:30-d2e5035-04242ac/linux-ppc64-buildlet
2021-10-05T21:25:51-d4b1ae0-6ae3afa/illumos-amd64
2021-10-05T21:25:51-d4b1ae0-6ae3afa/linux-ppc64-buildlet
2021-10-05T20:57:56-d4b1ae0-55e7f7e/linux-ppc64le-power9osu
2021-10-05T20:53:02-d4b1ae0-695a59b/linux-ppc64le-buildlet
2021-10-05T20:35:54-d4b1ae0-990c9c6/linux-ppc64-buildlet
2021-10-05T20:35:54-d4b1ae0-990c9c6/linux-ppc64le-buildlet
2021-10-05T19:28:36-d4b1ae0-7ae83c8/illumos-amd64
2021-10-05T16:06:49-d4b1ae0-060cd73/linux-ppc64le-buildlet
2021-10-05T14:12:44-d4b1ae0-7983830/android-amd64-emu
2021-10-05T00:29:40-d4b1ae0-81b7ec1/linux-ppc64-buildlet
2021-10-05T00:13:12-d4b1ae0-04242ac/windows-arm64-10
2021-10-04T23:29:20-69340ce-e5f6d8d/linux-ppc64-buildlet
2021-10-04T22:27:40-69340ce-752cc07/android-386-emu
2021-10-04T22:05:34-69340ce-d9952ff/android-386-emu
2021-10-04T22:05:34-69340ce-7d57324/linux-ppc64le-buildlet
2021-10-04T22:05:34-69340ce-7d57324/linux-ppc64le-power9osu
2021-10-04T22:05:34-69340ce-7d57324/windows-386-2008
2021-10-04T22:05:34-69340ce-04242ac/windows-arm64-10
2021-10-04T21:10:16-b30845b-f0db7ea/linux-ppc64le-power9osu
2021-10-04T21:10:16-b30845b-f0db7ea/windows-arm64-10
2021-10-04T19:51:37-b30845b-579ff8b/linux-ppc64le-power9osu
2021-10-04T19:50:52-b30845b-04242ac/illumos-amd64
2021-10-04T17:17:11-cedda3a-cc5e3de/illumos-amd64
2021-10-04T17:17:11-cedda3a-cc5e3de/linux-ppc64le-buildlet

The first failures appear to be at CL 353390. (CC @neild @bradfitz)
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 14, 2021
@bcmills bcmills added this to the Go1.18 milestone Oct 14, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 14, 2021 

--- FAIL: TestTransportRetriesOnStreamProtocolError (0.00s)
    transport_test.go:5474: unexpected body read 0, unexpected EOF
FAIL
FAIL	golang.org/x/net/http2	16.802s

@neild
Copy link
Contributor

neild commented Oct 15, 2021

Should be fixed by CL 356029. (I put the wrong CL in the description.)

@neild neild closed this as completed Oct 15, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 15, 2021

Seems not to be, unfortunately:

greplogs --dashboard -md -l -e 'FAIL: TestTransportRetriesOnStreamProtocolError' --since=2021-10-15

2021-10-15T18:07:49-db2dff3-8331f25/linux-ppc64le-buildlet
2021-10-15T18:07:49-db2dff3-8331f25/linux-ppc64le-power9osu
2021-10-15T17:46:53-db2dff3-8c99421/linux-ppc64le-power9osu

@bcmills bcmills reopened this Oct 15, 2021
@neild
Copy link
Contributor

neild commented Oct 15, 2021

Sigh. I will go hit it with the flakehammer some more.

@neild neild self-assigned this Oct 15, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/356329 mentions this issue: http2: deflake TestTransportRetriesOnStreamProtocolError

dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@neild
http2: deflake TestTransportRetriesOnStreamProtocolError
7a080b5 
During this test:
  -> client sends req1
  <- server sends req1 headers
  -> client sends req2
  <- server resets req2
  <- server sends END_STREAM for req1
  -> client closes the *server* connection

The flake occurs when the last two steps happen out of order: The
client processes the reset for req2, returns from RoundTrip, and
the test closes the connection before the server writes the last
DATA frame for req1. This can be demonstrated by inserting a 1ms
sleep between WriteRSTStream and WriteData on the server side of
the test.

It isn't clear why the client side of the test is closing the server
side of the connection; it isn't essential to the test in any way.
Remove it.

Fixes golang/go#48994.

Change-Id: If074e45a76205ebd245617ef1b068967a6674b94
Reviewed-on: https://go-review.googlesource.com/c/net/+/356329
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@rsc rsc unassigned neild Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@neild @bcmills @gopherbot