Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: coordinator shouldn't wait forever for builders that do not snapshot #49400

Open
toothrot opened this issue Nov 5, 2021 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@toothrot
Copy link
Contributor

toothrot commented Nov 5, 2021

In https://golang.org/cl/361754 (#49207), a builder was corrected to SkipSnapshot when it doesn't build the go repo. The following code will loop forever in this scenario, as a snapshot will never be uploaded for this configuration:

https://cs.opensource.google/go/x/build/+/master:cmd/coordinator/coordinator.go;l=1016;drc=0f6a98d88fcd2f596743aecbdc5b3def2458eded

A test should fail if this invalid configuration occurs.

@toothrot toothrot added the Builders x/build issues (builders, bots, dashboards) label Nov 5, 2021
@toothrot toothrot added this to the Unreleased milestone Nov 5, 2021
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. labels Nov 5, 2021
@cagedmantis cagedmantis added this to Planned in Go Release Team Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Development

No branches or pull requests

2 participants