gccgo: fails to order evaluation of some bound method expression thunks

[ianlancetaylor]

This test case panics when compiled with gccgo. I'm working on a fix.

package main

type S struct{
	m1Called, m2Called bool
}

func (s *S) M1(int) (int, int) {
	s.m1Called = true
	return 0, 0
}

func (s *S) M2(int) (int, int) {
	s.m2Called = true
	return 0, 0
}

type C struct {
	calls []func(int) (int, int)
}

func makeC() Funcs {
	return &C{}
}

func (c *C) Add(fn func(int) (int, int)) Funcs {
	c.calls = append(c.calls, fn)
	return c
}

func (c *C) Call() {
	for _, fn := range c.calls {
		fn(0)
	}
}

type Funcs interface {
	Add(func(int) (int, int)) Funcs
	Call()
}

func main() {
	s := &S{}
	c := makeC().Add(s.M1).Add(s.M2)
	c.Call()
	if !s.m1Called || !s.m2Called {
		panic("missed method call")
	}
}

[gopherbot]

Change https://golang.org/cl/363156 mentions this issue: test: add test that was miscompiled by gccgo

[gopherbot]

Change https://golang.org/cl/363274 mentions this issue: compiler: traverse func subexprs when creating func descriptors