Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: may select wrong current milestone if there are duplicates #50199

Closed
dmitshur opened this issue Dec 15, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

Releasebot looks for the release milestone for the current release, and uses it for various things during the release process.

GitHub allows for multiple milestones to have the same title that differ only in case. If a duplicate open milestone exists (this may happen, for example, if a duplicate milestone is created accidentally), releasebot currently may pick the wrong milestone, which negatively impacts its behavior.

I'll send a CL to update releasebot to look for duplicate open milestones, and report it as a fatal problem if so (since humans will need to figure out how to deal with it), like so:

cannot find the GitHub milestone for release go1.18beta1: found closed or duplicate milestones:
	• open milestone "go1.18" (https://github.com/golang/go/milestone/241)
	• open milestone "Go1.18" (https://github.com/golang/go/milestone/201)
exit status 1

I'll also close (and after some time passes, delete) the empty second "go1.18" milestone that I understand was created accidentally. (Not to be confused with the real Go1.18 milestone.)

CC @golang/release, @cherrymui.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Dec 15, 2021
@dmitshur dmitshur added this to the Unreleased milestone Dec 15, 2021
@dmitshur dmitshur self-assigned this Dec 15, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/372534 mentions this issue: cmd/releasebot: ensure no duplicate release milestones exist

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants