Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: remove bitbucket VCS probing #50810

Closed
bcmills opened this issue Jan 25, 2022 · 5 comments
Closed

cmd/go: remove bitbucket VCS probing #50810

bcmills opened this issue Jan 25, 2022 · 5 comments
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Jan 25, 2022

The go command previously probed bitbucket servers in case of a 403 status to figure out which VCS command (git or hg) to use to fetch repositories hosted on Bitbucket.

Bitbucket no longer supports hg (https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket), and per discussion on CL 371720 they would like to change the status code returned by their servers — an implementation detail currently hard-coded by go get.

Since the choice of VCS tool is no longer ambiguous, we should remove the VCS probing logic. That will also make the go command's behavior for private Bitbucket repos more closely match its behavior for other private repos in general.

@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. GoCommand cmd/go modules labels Jan 25, 2022
@bcmills bcmills added this to the Go1.18 milestone Jan 25, 2022
@bcmills
Copy link
Member Author

bcmills commented Jan 25, 2022

@gopherbot, please backport to Go 1.16 and 1.17. This removes a dependency on an implementation detail of a service external to the Go project.

@gopherbot
Copy link

Backport issue(s) opened: #50811 (for 1.16), #50812 (for 1.17).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot
Copy link

Change https://golang.org/cl/371720 mentions this issue: cmd/go: remove mercurial from bitbucket vcs options

@gopherbot
Copy link

Change https://golang.org/cl/380996 mentions this issue: cmd/go: remove mercurial from bitbucket vcs options

@gopherbot
Copy link

Change https://golang.org/cl/380998 mentions this issue: [release-branch.go1.16] cmd/go: remove mercurial from bitbucket vcs options

gopherbot pushed a commit that referenced this issue Feb 7, 2022
…ptions

Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket

Fixes #50812.
Updates #50810.

Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/371720
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Bryan Mills <bcmills@google.com>
(cherry picked from commit 5b1b80b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/380996
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot pushed a commit that referenced this issue Feb 7, 2022
…ptions

Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket

Fixes #50811.
Updates #50810.

Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/371720
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Bryan Mills <bcmills@google.com>
(cherry picked from commit 5b1b80b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/380998
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
jproberts pushed a commit to jproberts/go that referenced this issue Jun 21, 2022
Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket

Fixes golang#50810.

Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/371720
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants