Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/doc/workspace.md: rewrite to mention go.work #51206

Closed
hyangah opened this issue Feb 15, 2022 · 5 comments
Closed

x/tools/gopls/doc/workspace.md: rewrite to mention go.work #51206

hyangah opened this issue Feb 15, 2022 · 5 comments
Labels
Documentation FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 15, 2022

We also need to update diagnostics error messages in gopls too.
Screen Shot 2022-02-15 at 9 04 16 AM
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 15, 2022
@gopherbot gopherbot added this to the Unreleased milestone Feb 15, 2022
@hyangah hyangah added Documentation and removed gopls Issues related to the Go language server, gopls. labels Feb 15, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/v0.8.0 Feb 15, 2022
@findleyr
Copy link
Contributor

Thanks for the report. Tentatively assigning to @matloob

@findleyr
Copy link
Contributor

It would also be good to update our instructions for working on the Go repo.

@hyangah hyangah mentioned this issue Feb 22, 2022
Closed
@findleyr
Copy link
Contributor

findleyr commented Mar 1, 2022

I'll take this, as workspaces are being discussed in slack and I'd like to be able to point users to documentation.

@findleyr findleyr assigned findleyr and unassigned matloob Mar 1, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/388994 mentions this issue: gopls/doc: update the documentatino for workspaces to suggest go.work

gopherbot pushed a commit to golang/tools that referenced this issue Mar 2, 2022
@findleyr
gopls/doc: update the documentation for workspaces to suggest go.work
abbbcaf 
For golang/go#51206

Change-Id: I6d2b137afe0222d0ef8e87869111b148931d4fac
Reviewed-on: https://go-review.googlesource.com/c/tools/+/388994
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/389234 mentions this issue: gopls/doc: address additional comments on workspace.md

gopherbot pushed a commit to golang/tools that referenced this issue Mar 2, 2022
@findleyr
gopls/doc: address additional comments on workspace.md
afc5fce 
This CL addresses an additional comment from CL 388994, changing the
example to move the go.work file outside of the repo.

For golang/go#51206

Change-Id: I576615f9bbcc676f3f78a959ad509b9dbab3b00e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/389234
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@findleyr findleyr closed this as completed Mar 3, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.0
Development

No branches or pull requests
4 participants
@hyangah @gopherbot @matloob @findleyr