gollvm: can't use unsafe.Pointer as map key

[erifan]

What version of Go are you using (go version)?

$ go version
Gollvm tip version

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
linux/arm64

What did you do?

$ llvm-goc -c foo.go
$ cat foo.go

package foo

import (
        "unsafe"
)

// if the key of the map is not unsafe.Pointer, then the program compiles.
var newCache map[unsafe.Pointer]int

func mapCopy(k unsafe.Pointer, v int) {
        newCache = make(map[unsafe.Pointer]int, 1)
        newCache[k] = v
        return
}

What did you expect to see?

No error

What did you see instead?

Call parameter type does not match function signature!
%.ld.1 = load i8, i8* %tmpv.4.ld.0, align 1, !dbg !57
i8* %call.1 = call i8* @runtime.mapassign__fast64ptr(i8* nest undef, %_type.0* getelementptr inbounds (%MapType.0, %MapType.0* @type..map_6unsafe_0Pointer_7int, i32 0, i32 0), { i64, i8, i8, i16, i32, i8*, i8*, i64, i8* }* %go_0foo.newCache.ld.0, i8 %.ld.1), !dbg !57
Call parameter type does not match function signature!
%.ld.1 = load i8, i8* %tmpv.4.ld.0, align 1, !dbg !57
i8* %call.1 = call i8* @runtime.mapassign__fast64ptr(i8* nest undef, %_type.0* getelementptr inbounds (%MapType.0, %MapType.0* @type..map_6unsafe_0Pointer_7int, i32 0, i32 0), { i64, i8, i8, i16, i32, i8*, i8*, i64, i8* }* %go_0foo.newCache.ld.0, i8 %.ld.1), !dbg !57
in function go_0foo.mapCopy
LLVM ERROR: Broken function found, compilation aborted!
#0 0x0000aaaad7616c9c PrintStackTraceSignalHandler(void*) Signals.cpp:0:0
#1 0x0000aaaad7614dc4 SignalHandler(int) Signals.cpp:0:0
#2 0x0000ffffbb06e66c (linux-vdso.so.1+0x66c)
#3 0x0000ffffbab654f8 gsignal /build/glibc-D9JkfM/glibc-2.27/signal/../sysdeps/unix/sysv/linux/raise.c:51:0
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0, Program arguments: llvm-goc -c foo.go
1, Running pass 'Module Verifier' on function '@go_0foo.mapCopy'
Aborted (core dumped)

[beoran]

I think you should probably use uintptr in stead.

[randall77]

@thanm

[thanm]

Thanks for the report, I'll take a look.

[thanm]

Looks like this was fixed by https://go-review.googlesource.com/c/gollvm/+/393295 -- thanks.