Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflect: can set map elem with string key of a different string type [1.18 backport] #52386

Closed
gopherbot opened this issue Apr 16, 2022 · 2 comments
Closed

reflect: can set map elem with string key of a different string type [1.18 backport] #52386

gopherbot opened this issue Apr 16, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.2

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #52379 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18.

The reflect package incorrectly accepts this case. This should be fixed so that we don't have programs that work with the current release and fail with the next release.

Earlier releases correctly panic.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 16, 2022
@gopherbot gopherbot mentioned this issue Apr 16, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.2 milestone Apr 16, 2022
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label May 4, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 4, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/404000 mentions this issue: reflect: ensure map keys match key type in MapIndex and SetMapIndex

@gopherbot
Copy link
Author

Closed by merging 0287895 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
@kortschak @heschi
[release-branch.go1.18] reflect: ensure map keys match key type in Ma…
0287895 
…pIndex and SetMapIndex

name                          old time/op    new time/op    delta
Map/StringKeys/MapIndex-8           2.36µs ± 5%    2.55µs ±11%  +7.98%  (p=0.006 n=10+9)
Map/StringKeys/SetMapIndex-8        4.86µs ± 7%    4.77µs ± 1%    ~     (p=0.211 n=10+9)
Map/StringKindKeys/MapIndex-8       2.29µs ± 3%    2.28µs ± 4%    ~     (p=0.631 n=10+10)
Map/StringKindKeys/SetMapIndex-8    4.44µs ± 3%    4.61µs ± 1%  +3.78%  (p=0.000 n=10+10)
Map/Uint64Keys/MapIndex-8           3.42µs ± 9%    3.11µs ± 2%  -9.20%  (p=0.000 n=10+9)
Map/Uint64Keys/SetMapIndex-8        5.17µs ± 3%    5.00µs ± 1%  -3.23%  (p=0.000 n=9+10)

For #52379
Fixes #52386

Change-Id: I545c71ea3145280828ca4186aad036a6c02016ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/400635
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
(cherry picked from commit 11a650b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/404000
Reviewed-by: David Chase <drchase@google.com>
@golang golang locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.2
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot