Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: add a Go GC guide #53360

Open
mknyszek opened this issue Jun 13, 2022 · 2 comments
Open

x/website: add a Go GC guide #53360

mknyszek opened this issue Jun 13, 2022 · 2 comments
Assignees
Labels
Documentation NeedsFix okay-after-beta1 release-blocker website
Milestone

Comments

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Jun 13, 2022

As part of #48409 I proposed adding a new guide for the Go GC. This is an issue to track that work.

@mknyszek mknyszek self-assigned this Jun 13, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jun 13, 2022
@mknyszek mknyszek removed this from the Unreleased milestone Jun 13, 2022
@mknyszek mknyszek added this to the Go1.19 milestone Jun 13, 2022
@mknyszek mknyszek added NeedsFix Documentation okay-after-beta1 labels Jun 13, 2022
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 13, 2022

Change https://go.dev/cl/411954 mentions this issue: _content/doc: add work-in-progress gc-guide.html

gopherbot pushed a commit to golang/website that referenced this issue Jun 13, 2022
Currently we're publishing links to go.dev/doc/gc-guide but these links
are broken. I'm currently working on this, but at the very least let's
publish a work-in-progress page so that the status is clearer to those
who click the link.

For golang/go#53360.
Fixes golang/go#53337.

Change-Id: Id3c6107d25ce9980e88d53c8ba6ec5b4349aa29f
Reviewed-on: https://go-review.googlesource.com/c/website/+/411954
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@mknyszek
Copy link
Contributor Author

@mknyszek mknyszek commented Jun 13, 2022

Note for release folks: I marked this as a release blocker because we have outstanding links to this guide and work-in-progress page that mentions expected availability around the time of the 1.19 release.

However, this is not a hard blocker. If need be, we can drop this and update the work-in-progress page with a new expectation. I fully intend to have it ready before then, but if for some reason that becomes impossible, this issue is still useful for tracking the work to either update that work-in-progress page, or delete the links (from the SetMemoryLimit documentation, added in Go 1.19, and the Go 1.19 release notes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation NeedsFix okay-after-beta1 release-blocker website
Projects
Status: No status
Development

No branches or pull requests

2 participants