x/pkgsite: bsd-4-clause link is broken

[willfaught]

What is the URL of the page with the issue?

https://pkg.go.dev/license-policy

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.6 Safari/605.1.15

Screenshot

What did you do?

• Went to https://pkg.go.dev/license-policy
• Clicked on the "BSD-4-Clause" and "BSD-4-Clause-UC" links.

What did you expect to see?

Links work

What did you see instead?

404

---

The links are https://opensource.org/licenses/BSD-4-Clause and https://opensource.org/licenses/BSD-4-Clause-UC.

What were probably intended were https://spdx.org/licenses/BSD-4-Clause.html and https://spdx.org/licenses/BSD-4-Clause-UC.html.

[willfaught]

More:

• https://opensource.org/licenses/AGPL-3.0-only
• https://opensource.org/licenses/BSD-3-Clause-Open-MPI
• https://opensource.org/licenses/BSD-3-Clause-Clear
• https://opensource.org/licenses/BSD-3-Clause-LBNL
• https://opensource.org/licenses/BSD-3-Clause-Open-MPI

I guess just test them all.

[kucukaslan]

It seems those licenses are not OSI approved licences¹ but the pkgsite generates the URLs as if they're OSI approved. I think adding them to nonOSILicenses map in the website source code would fix it. I'll give it a try and open a PR to fix.

Footnotes

1. https://opensource.org/licenses/alphabetical ↩

[gopherbot]

Change https://go.dev/cl/425368 mentions this issue: internal/licenses: update the list of licenses not approved by OSI