cmd/go: data race in TestScript [1.19 backport] #54637
Labels
CherryPickApproved
Used during the release process for point releases
FrozenDueToAge
GoCommand
cmd/go
Milestone
Comments
gopherbot
added
the
CherryPickCandidate
|
This is a data race in cmd/go tests, and the fix is low-risk. |
bcmills
added
CherryPickApproved
gopherbot
removed
the
CherryPickCandidate
|
Change https://go.dev/cl/425207 mentions this issue: |
|
Closed by merging 4b1c16c to release-branch.go1.19. |
gopherbot
pushed a commit
that referenced
this issue
Aug 29, 2022
…tests Ever since 'go build' was added (in CL 5483069), it has used an atexit handler to clean up working directories. CL 154109 introduced 'cc' command to the script test framework that called Init on a builder once per invocation. Unfortunately, since base.AtExit is unsynchronized, the Init added there caused any script that invokes that command to be unsafe for concurrent use. This change fixes the race by having the 'cc' command pass in its working directory instead of allowing the Builder to allocate one. Following modern Go best practices, it also replaces the in-place Init method (which is prone to typestate and aliasing bugs) with a NewBuilder constructor function. Updates #54423. Fixes #54637. Change-Id: I8fc2127a7d877bb39a1174e398736bb51d03d4d2 Reviewed-on: https://go-review.googlesource.com/c/go/+/425205 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Than McIntosh <thanm@google.com> (cherry picked from commit d5aa088) Reviewed-on: https://go-review.googlesource.com/c/go/+/425207
bradfitz
pushed a commit
to tailscale/go
that referenced
this issue
Sep 8, 2022
…tests Ever since 'go build' was added (in CL 5483069), it has used an atexit handler to clean up working directories. CL 154109 introduced 'cc' command to the script test framework that called Init on a builder once per invocation. Unfortunately, since base.AtExit is unsynchronized, the Init added there caused any script that invokes that command to be unsafe for concurrent use. This change fixes the race by having the 'cc' command pass in its working directory instead of allowing the Builder to allocate one. Following modern Go best practices, it also replaces the in-place Init method (which is prone to typestate and aliasing bugs) with a NewBuilder constructor function. Updates golang#54423. Fixes golang#54637. Change-Id: I8fc2127a7d877bb39a1174e398736bb51d03d4d2 Reviewed-on: https://go-review.googlesource.com/c/go/+/425205 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Than McIntosh <thanm@google.com> (cherry picked from commit d5aa088) Reviewed-on: https://go-review.googlesource.com/c/go/+/425207
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@bcmills requested issue #54423 to be considered for backport to the next 1.19 minor release.
The text was updated successfully, but these errors were encountered: