Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/gopath_moved_repo flake #54933

Closed
mknyszek opened this issue Sep 7, 2022 · 4 comments
Closed

cmd/go: TestScript/gopath_moved_repo flake #54933

mknyszek opened this issue Sep 7, 2022 · 4 comments
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Sep 7, 2022

2022-09-01T23:18:01-a74d46d/linux-amd64-longtest

Might be related to #52820.

CC @bcmills

@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 7, 2022
@mknyszek mknyszek added this to the Go1.20 milestone Sep 7, 2022
@bcmills bcmills added the GoCommand cmd/go label Sep 7, 2022
@bcmills
Copy link
Member

bcmills commented Sep 7, 2022

The git trace from the test log:

            > [exec:git] ! go get -d -u rsc.io/pdf
            [stderr]
            # cd $WORK/gopath/src/rsc.io/pdf; git pull --ff-only
            23:45:49.720171 http.c:756              == Info: Couldn't find host github.com in the .netrc file; using defaults
            23:45:49.746088 http.c:756              == Info:   Trying 140.82.112.3:443...
            23:45:49.770382 http.c:756              == Info: Connected to github.com (140.82.112.3) port 443 (#0)
…
            remote: Repository not found.
            fatal: Authentication failed for 'https://github.com/rsc/pdfXXX/'
            package rsc.io/pdf: exit status 1
            [exit status 1]

@bcmills
Copy link
Member

bcmills commented Sep 7, 2022

I don't think this test is supposed to be trying to fetch from github.com/rsc/pdfXXX at all: it is supposed to notice that the go-import path doesn't match and bail at that point.

The repo check is here:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/get/get.go;l=466-486;drc=9e6cd3985dbcdcfe0ed2075be6dbe8c5d6de59cb

Notably, if the call to rr.VCS.ResolveRepo fails, the code proceeds with the repo location from GOPATH.

I suspect that in this case that call failed due to #49954 or a related error connecting to rsc.io.

@bcmills
Copy link
Member

bcmills commented Sep 7, 2022

Probably the long-term fix for this is to migrate the tests away from the external rsc.io server (using the same mechanism as #27494).

@bcmills
Copy link
Member

bcmills commented Sep 8, 2022

Duplicate of #49954

@bcmills bcmills marked this as a duplicate of #49954 Sep 8, 2022
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2022
@golang golang locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants