Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestBoringAllowCert failures [1.19 backport] #57635

Closed
gopherbot opened this issue Jan 5, 2023 · 3 comments
Closed

crypto/x509: TestBoringAllowCert failures [1.19 backport] #57635

gopherbot opened this issue Jan 5, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19.6

Comments

@gopherbot
Copy link

@bcmills requested issue #56798 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19. This test is still flaky on the release branch.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 5, 2023
@gopherbot gopherbot mentioned this issue Jan 5, 2023
Closed
@gopherbot gopherbot added this to the Go1.19.5 milestone Jan 5, 2023
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 6, 2023
@gopherbot gopherbot modified the milestones: Go1.19.5, Go1.19.6 Jan 10, 2023
@cagedmantis
Copy link
Contributor

This is approved as it is a test only change and it's something that has impacted the release in the past.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Jan 11, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 11, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/461615 mentions this issue: [release-branch.go1.19] crypto/x509: reduce boring test key size

@gopherbot
Copy link
Author

Closed by merging f38c1eb to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Jan 17, 2023
@rolandshoemaker @cagedmantis
[release-branch.go1.19] crypto/x509: reduce boring test key size
f38c1eb 
Generating 8192 bit keys times out on builders relatively frequently. We
just need something that isn't a boringAllowCert allowed key size so we
can test that a non-boringAllowCert signed intermediate works, so just
use 512 instead since it'll be significantly faster.

Fixes #57635
Updates #56798

Change-Id: I416e0d8c3aa11ff44e9870755efa95c74d1013f1
Reviewed-on: https://go-review.googlesource.com/c/go/+/451656
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 38b9ff6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/461615
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
@golang golang locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19.6
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot