New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/exec: flaky TestExtraFilesFDShuffle is disabled #5780

Open
gopherbot opened this Issue Jun 25, 2013 · 12 comments

Comments

Projects
None yet
7 participants
@gopherbot
Copy link

gopherbot commented Jun 25, 2013

by capnm9:

hg id
29818ed2e3f7 tip

uname -a
Linux rpi 3.6.11+ #456 PREEMPT Mon May 20 17:42:15 BST 2013 armv6l GNU/Linux

ok      os  2.776s
--- FAIL: TestExtraFilesFDShuffle (0.14 seconds)
    exec_test.go:248: bad test value for test pipe: fd 4
    exec_test.go:278: bad test value for stderr pipe
FAIL
FAIL    os/exec 5.216s
ok      os/signal   0.764s

(not sure which commit brought this)
@alberts

This comment has been minimized.

Copy link
Contributor

alberts commented Jun 25, 2013

Comment 1:

This happened here:
https://code.google.com/p/go/source/detail?r=600c5389c9d3
Discussed it here:
https://golang.org/cl/9103045
No feedback from the original author/committer though.
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jun 25, 2013

Comment 2 by capnm9:

In context of #1:
It failed by running ./all.bash without any environment changes.
The failure was 100% reproducible but is now gone after
reboot.
The system was up about 2 weeks. I did't found anything unusual.
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jun 27, 2013

Comment 3 by capnm9:

It happened again:
uptime
 09:07:00 up 1 day, 13:30,  2 users,  load average: 0,00, 0,01, 0,05
hg id
c96951f239c0 tip
1) At some point in time all.bash starts failing in this test.
2) After a reboot all.bash runs successfully again, goto 1)
This is weird. There are no stalled processes or extra allocated RAM.
@fullung Do you have an idea where I should look?
@alberts

This comment has been minimized.

Copy link
Contributor

alberts commented Jun 27, 2013

Comment 4:

I haven't had time to look at it in detail, but I'm pretty sure the test is closing file
descriptors it shouldn't.
@davecheney

This comment has been minimized.

Copy link
Contributor

davecheney commented Jul 2, 2013

Comment 5:

--- FAIL: TestExtraFilesFDShuffle (0.02 seconds)
        exec_test.go:247: bad test value for test pipe: fd 4
        exec_test.go:277: bad test value for stderr pipe
FAIL
FAIL    os/exec 0.336s
Happened twice in a row on linux/amd64
% hg id
fd0b7333b96b+ tip
Marking as Soon / 1.2 because it will eventually start to cause our builders to fail.

Labels changed: added priority-soon, go1.2, removed priority-triage.

Status changed to Accepted.

@dsymonds

This comment has been minimized.

Copy link
Member

dsymonds commented Aug 21, 2013

Comment 6:

Owner changed to @bradfitz.

@lexprfuncall

This comment has been minimized.

Copy link

lexprfuncall commented Aug 23, 2013

Comment 7:

This issue was updated by revision 221eef6.

R=golang-dev, cshapiro, dave, bradfitz
CC=golang-dev
https://golang.org/cl/12869049
@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Sep 4, 2013

Comment 8:

Removing Go1.2 label. The test is now disabled.
This bug is now about making the test not flaky and re-enabling it.

Labels changed: added priority-someday, removed priority-soon, go1.2.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Nov 27, 2013

Comment 9:

Labels changed: added go1.3maybe.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Dec 4, 2013

Comment 10:

Labels changed: added release-none, removed go1.3maybe.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Dec 4, 2013

Comment 11:

Labels changed: added repo-main.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Feb 4, 2014

Comment 12:

Owner changed to ---.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment