Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/internal/task/releaselet: change the minimum Windows version in the installer #58028

Closed
cagedmantis opened this issue Jan 26, 2023 · 3 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Milestone

Comments

@cagedmantis
Copy link
Contributor

As proposed in #57003 and #57004, the minimum supported version of Windows will be changing for the go1.21 release. The packager configuration should reflect that change before the release. There are also various other updates that can happen to the packager script. Such as:

cc @golang/release

@cagedmantis cagedmantis added OS-Windows NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jan 26, 2023
@cagedmantis cagedmantis added this to the Go1.21 milestone Jan 26, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 26, 2023
@gopherbot
Copy link

Change https://go.dev/cl/478616 mentions this issue: internal/task/releaselet: update for 1.21

@heschi heschi self-assigned this Mar 22, 2023
gopherbot pushed a commit to golang/build that referenced this issue Mar 24, 2023
Attempt to require Windows 10 in the installer for 1.21.

Also use go.dev everywhere. This will take effect in the next minor
releases.

For golang/go#58028

Change-Id: I6786b0ec143fcec62f38d72fce0c8b1170c0e4e7
Reviewed-on: https://go-review.googlesource.com/c/build/+/478616
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@heschi
Copy link
Contributor

heschi commented Mar 24, 2023

I did most of this, and #57413 is still open, so I consider this issue fixed.

@heschi heschi closed this as completed Mar 24, 2023
@gopherbot
Copy link

Change https://go.dev/cl/479277 mentions this issue: internal/task/releaselet: fix

gopherbot pushed a commit to golang/build that referenced this issue Mar 24, 2023
I forgot to upload the latest patchset to http://go.dev/cl/478616 before
submitting :(

For golang/go#58028

Change-Id: Ic8c06a99341472c774ce4e44cf8f3b98b5e70a13
Reviewed-on: https://go-review.googlesource.com/c/build/+/479277
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Projects
Archived in project
Development

No branches or pull requests

3 participants