Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Add opensearch / Tab To Search #58133

Open
Jille opened this issue Jan 29, 2023 · 3 comments
Open

x/pkgsite: Add opensearch / Tab To Search #58133

Jille opened this issue Jan 29, 2023 · 3 comments
Labels
FeatureRequest pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/later

Comments

@Jille
Copy link

Jille commented Jan 29, 2023

Having opensearch set up would be great. It allows users to type pkg.go.dev<tab>package name<enter> and go to their package, rather than first waiting for pkg.go.dev to load and then type into the search bar there.

godoc.org had this functionality. I've ported it to pkg.go.dev, I'll send a CL/PR shortly.

/assign Jille
@gopherbot gopherbot added this to the Unreleased milestone Jan 29, 2023
@Jille Jille mentioned this issue Jan 29, 2023
Open
@Jille
Copy link
Author

Jille commented Jan 29, 2023

@SnoozeThis https://go-review.googlesource.com/c/pkgsite/+/463986

@SnoozeThis
Copy link

(https://snoozeth.is/IRue6A9hYdw) I will wait until https://go-review.googlesource.com/c/463986 is merged and then add a comment.

Jille added a commit to Jille/pkgsite that referenced this issue Jan 29, 2023
@Jille
frontend: Set up opensearchdescription aka Tab To Search
711a91d 
This used to work on godoc.org, let's set it up for pkg.go.dev too.

golang/go#58133
@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Feb 2, 2023
@hyangah
Copy link
Contributor

hyangah commented Feb 2, 2023

I manually set up the search to tab (for example, chrome://settings/searchEngine) but this may be convenient.

cc @golang/tools-team

@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/later
Development

No branches or pull requests
4 participants
@Jille @hyangah @gopherbot @SnoozeThis