Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestTransportConnectionCloseOnResponse/h2 failures with unexpected bodiesDiffer=false #58258

Open
gopherbot opened this issue Feb 2, 2023 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Feb 2, 2023

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnResponse" && `unexpected bodiesDiffer=false`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportConnectionCloseOnResponse (0.00s)
    --- FAIL: TestTransportConnectionCloseOnResponse/h2 (0.82s)
        transport_test.go:238: error in connectionClose=true. unexpected bodiesDiffer=false; body1="127.0.0.1:13438"; body2="127.0.0.1:13438"

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2023
@gopherbot

This comment was marked as off-topic.

@bcmills
Copy link
Member

bcmills commented Feb 2, 2023

The freebsd-arm-paulzhol failure looks real, and may be related to #57476 (attn @paulzhol; CC @neild).
See previously #38413.

The other two are #58168.

@bcmills bcmills added this to the Backlog milestone Feb 2, 2023
@cherrymui cherrymui changed the title net/http: TestTransportConnectionCloseOnResponse failures net/http: TestIssue4191_InfiniteGetTimeout data race Feb 2, 2023
@cherrymui cherrymui changed the title net/http: TestIssue4191_InfiniteGetTimeout data race net/http: TestTransportConnectionCloseOnResponse Feb 2, 2023
@cherrymui cherrymui changed the title net/http: TestTransportConnectionCloseOnResponse net/http: TestTransportConnectionCloseOnResponse failure Feb 2, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnResponse" && `unexpected bodiesDiffer`
2023-03-15 13:30 freebsd-arm-paulzhol go@a8cd10f2 net/http.TestTransportConnectionCloseOnResponse (log)
--- FAIL: TestTransportConnectionCloseOnResponse (0.00s)
    --- FAIL: TestTransportConnectionCloseOnResponse/h2 (1.29s)
        transport_test.go:238: error in connectionClose=true. unexpected bodiesDiffer=false; body1="127.0.0.1:11773"; body2="127.0.0.1:11773"
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false

watchflakes

@bcmills bcmills removed the OS-FreeBSD label Apr 7, 2023
@bcmills bcmills changed the title net/http: TestTransportConnectionCloseOnResponse failure net/http: TestTransportConnectionCloseOnResponse/h2 failures with 'unexpected bodiesDiffer=false` Apr 7, 2023
@bcmills bcmills changed the title net/http: TestTransportConnectionCloseOnResponse/h2 failures with 'unexpected bodiesDiffer=false` net/http: TestTransportConnectionCloseOnResponse/h2 failures with unexpected bodiesDiffer=false Apr 7, 2023
@bcmills
Copy link
Member

bcmills commented Apr 7, 2023

(CC @neild @paulzhol)

I'm not sure whether this failure mode is fixed by CL 483116. (I suspect not, because the two failures with this signature are in the /h2 subtest, and IIUC that fix only really affects HTTP/1.)

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnResponse" && `unexpected bodiesDiffer=false`
2023-10-05 18:07 netbsd-arm-bsiegert go@2ddfc04d net/http.TestTransportConnectionCloseOnResponse (log)
--- FAIL: TestTransportConnectionCloseOnResponse (0.00s)
    --- FAIL: TestTransportConnectionCloseOnResponse/h1 (0.85s)
        transport_test.go:240: error in connectionClose=true. unexpected bodiesDiffer=false; body1="127.0.0.1:63073"; body2="127.0.0.1:63073"

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportConnectionCloseOnResponse" && `unexpected bodiesDiffer=false`
2024-01-10 19:40 netbsd-arm-bsiegert go@7e34c430 net/http.TestTransportConnectionCloseOnResponse (log)
--- FAIL: TestTransportConnectionCloseOnResponse (0.00s)
    --- FAIL: TestTransportConnectionCloseOnResponse/h1 (1.00s)
        transport_test.go:240: error in connectionClose=true. unexpected bodiesDiffer=false; body1="127.0.0.1:62186"; body2="127.0.0.1:62186"
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

2 participants