-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/perf/cmd/benchstat: no output #58576
Comments
can you provide zipped up versions of your input? |
@seankhliao sure |
That's a utf16le encoded text file, the tools should only work on utf8 |
I noticed that if I change this line (https://github.com/golang/perf/blob/801c7ef9e5c5eb8fb97c176023267056756fc52d/benchfmt/reader.go#L151) to: line := bytes.ReplaceAll(r.s.Bytes(), null, nil) Where It works properly |
I'm generating the files using |
that would be a powershell issue https://stackoverflow.com/questions/40098771/changing-powershells-default-output-encoding-to-utf-8 |
Thanks, that answers it! |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
The benchstat output
What did you see instead?
No output at all
If I run
benchstat
only with no arguments I get:Meaning benchstat is properly installed
I also tried:
benchstat old.txt new.txt > output.txt
Even though the output.txt file was created, it was empty.
Files used
old.txt
Contentnew.txt
ContentThe text was updated successfully, but these errors were encountered: