apply go 1.1.2 patches to release-branch.go1 #5928

adg · 2013-07-22T08:08:17Z

Here's the list of 1.1.2 issues:
https://code.google.com/p/go/issues/list?can=1&;q=label:Go1.1.2&sort=-closed&colspec=ID%20Status%20Stars%20Priority%20Owner%20Reporter%20Summary%20Closed

And here is the list of corresponding fixes, in the order they should be applied.

issue #4230 : cmd/gc: fix pointer composite literals in exported if statements.
https://code.google.com/p/go/source/detail?r=7639aa719ae8

issue #5755 : cmd/gc: fix missing export data for inlining in a few other cases.
https://code.google.com/p/go/source/detail?r=c224c549a3c7

issue #5745 : time: prevent a panic from leaving the timer mutex held
https://code.google.com/p/go/source/detail?r=974a69ed9fcf

issue #5753 : cmd/gc: fix issue with method wrappers not having escape analysis run on
them.
https://code.google.com/p/go/source/detail?r=58e15340e78f

issue #5809 : cmd/6g, cmd/8g: prevent constant propagation of non-constant LEA.
https://code.google.com/p/go/source/detail?r=cf792c00f410

issue #5724 : runtime: properly set G status after syscall
https://code.google.com/p/go/source/detail?r=fab6ba2a2d10

issue #5820 : cmd/8g: Make clearfat non-interleaved with pointer calculations.
https://code.google.com/p/go/source/detail?r=dc24634de6c5

issue #5922 : runtime: prevent sysmon from polling network excessivly
https://code.google.com/p/go/source/detail?r=6b3c351c7fe6

issue #5841 and issue #5905 are as-yet unresolved.

adg · 2013-07-22T08:16:31Z

Comment 1:

The correct patch for issue #4230 is
https://code.google.com/p/go/source/detail?r=d04e6b0bcacf

adg · 2013-07-22T08:22:33Z

Comment 3:

This issue was updated by revision 31a32150a72b.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11455045

adg · 2013-07-22T08:34:54Z

Comment 4:

This issue was updated by revision 7f7bdef7fc85.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11629044

adg · 2013-07-22T08:41:35Z

Comment 5:

This issue was updated by revision 2de1a6879076.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11666046

adg · 2013-07-22T13:45:31Z

Comment 6:

This issue was updated by revision e503b72350b2.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11669043

adg · 2013-07-22T22:00:03Z

Comment 7:

This issue was updated by revision 3f654997fdd6.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11515045

adg · 2013-07-22T23:40:51Z

Comment 8:

This issue was updated by revision 384bc9cc2853.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11698043

rsc · 2013-07-22T23:50:30Z

Comment 9:

The CLs listed in the initial report LGTM for inclusion in Go 1.1.2, except
that I am slightly concerned about
https://code.google.com/p/go/source/detail?r=6b3c351c7fe6. I hope that one
is okay.
Russ

adg · 2013-07-22T23:50:39Z

Comment 10:

This issue was updated by revision 6efaa14e2e7f.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11438044

adg · 2013-07-23T03:15:14Z

Comment 11:

All the patches listed above are now applied to the release branch, except for
  issue #5922  : runtime: prevent sysmon from polling network excessivly
  https://code.google.com/p/go/source/detail?r=6b3c351c7fe6
which is still under discussion. If it is to be applied, a patch will need to be written
by hand as the existing patch does not apply cleanly (it's a one line change, but the
change depends on the surrounding code).

rsc · 2013-07-25T13:42:48Z

Comment 12:

A new CL for 1.1.2
changeset:   17390:5baf6060648e
user:        Rémy Oudompheng <oudomphe@phare.normalesup.org>
date:        Thu Jul 25 09:42:05 2013 -0400
summary:     cmd/gc: avoid passing unevaluated constant expressions to backends.

rsc · 2013-07-25T13:58:22Z

Comment 13:

Two more CLs for 1.1.2. I believe this is all the outstanding bugs.
changeset:   17391:4d9c3095de9d
user:        Ian Lance Taylor <iant@golang.org>
date:        Thu Jul 25 09:53:57 2013 -0400
summary:     cmd/cgo: gccgo fixes
changeset:   17392:ba52f6399462
user:        Peter Mundy <go.peter.90@gmail.com>
date:        Thu Jul 25 09:56:06 2013 -0400
summary:     syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit

adg · 2013-07-25T23:36:14Z

Comment 14:

Also: 
changeset:   17387:3ffbc06b4874
user:        Andrew Gerrand <adg@golang.org>
date:        Thu Jul 25 11:29:13 2013 +1000
summary:     bufio: check buffer availability before reading in ReadFrom

adg · 2013-07-26T00:04:45Z

Comment 15:

This issue was updated by revision 8c514a33ecd0.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11879044

adg · 2013-07-28T23:57:54Z

Comment 16:

This issue was updated by revision 4e2d025187c6.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11887043

adg · 2013-07-29T00:34:56Z

Comment 17:

This issue was updated by revision 55ac276af5a7.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11996043

adg · 2013-07-29T08:01:05Z

Comment 18:

This issue was updated by revision a6a9792f94ac.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/12002043

adg · 2013-07-29T08:50:17Z

Comment 19:

Release notes started here: https://golang.org/cl/12016043

adg · 2013-08-13T05:19:29Z

Comment 20:

This issue was closed by revision 8c4c07b908e2.

Status changed to Fixed.

…rted if statements. ««« CL 10470043 / d04e6b0bcacf cmd/gc: fix pointer composite literals in exported if statements. Fixes #4230 (again). R=rsc, golang-dev, r CC=golang-dev https://golang.org/cl/10470043 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11455045

…n a few other cases. ««« CL 10464043 / c224c549a3c7 cmd/gc: fix missing export data for inlining in a few other cases. Exported inlined functions that perform a string conversion using a non-exported named type may miss it in export data. Fixes #5755. R=rsc, golang-dev, ality, r CC=golang-dev https://golang.org/cl/10464043 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11629044

…utex held ««« CL 10373047 / 974a69ed9fcf time: prevent a panic from leaving the timer mutex held When deleting a timer, a panic due to nil deref would leave a lock held, possibly leading to a deadlock in a defer. Instead return false on a nil timer. Fixes #5745. R=golang-dev, daniel.morsing, dvyukov, rsc, iant CC=golang-dev https://golang.org/cl/10373047 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11666046

…ing escape analysis run on them. ««« CL 10383048 / 58e15340e78f cmd/gc: fix issue with method wrappers not having escape analysis run on them. Escape analysis needs the right curfn value on a dclfunc node, otherwise it will not analyze the function. When generating method value wrappers, we forgot to set the curfn correctly. Fixes #5753. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/10383048 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11669043

…f non-constant LEA. ««« CL 10785043 / cf792c00f410 cmd/6g, cmd/8g: prevent constant propagation of non-constant LEA. Fixes #5809. R=golang-dev, dave, rsc, nigeltao CC=golang-dev https://golang.org/cl/10785043 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11515045

…nter calculations. ««« CL 11383043 / dc24634de6c5 cmd/8g: Make clearfat non-interleaved with pointer calculations. clearfat (used to zero initialize structures) will use AX for x86 block ops. If we write to AX while calculating the dest pointer, we will fill the structure with incorrect values. Since 64-bit arithmetic uses AX to synthesize a 64-bit register, getting an adress by indexing with 64-bit ops can clobber the register. Fixes #5820. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/11383043 »»» Update #5928 R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/11698043

…xcessivly ««« CL 11569043 / 6b3c351c7fe6 runtime: prevent sysmon from polling network excessivly If the network is not polled for 10ms, sysmon starts polling network on every iteration (every 20us) until another thread blocks in netpoll. Fixes issue 5922 . R=golang-dev, iant CC=golang-dev https://golang.org/cl/11569043 »»» Update #5928 R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/11438044

…ressions to backends. ««« CL 11107044 / 5baf6060648e cmd/gc: avoid passing unevaluated constant expressions to backends. Backends do not exactly expect receiving binary operators with constant operands or use workarounds to move them to register/stack in order to handle them. Fixes #5841. R=golang-dev, daniel.morsing, rsc CC=golang-dev https://golang.org/cl/11107044 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11879044

««« CL 11406047 / 4d9c3095de9d cmd/cgo: gccgo fixes Don't require a full-scale callback for calls to the special prologue functions. Always use a simple wrapper function for C functions, so that we can handle static functions defined in the import "C" comment. Disable a test that relies on gc-specific function names. Fixes #5905. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/11406047 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11887043

…and Setrlimit on Linux 32-bit ««« CL 11803043 / ba52f6399462 syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit The rlimit arguments for prlimit are reversed for linux 32-bit (386 and arm). Getrlimit becomes Setrlimit and vice versa. Fixes #5949. R=iant, mikioh.mikioh, rsc CC=golang-dev https://golang.org/cl/11803043 »»» Update #5928 R=golang-dev, dave CC=golang-dev https://golang.org/cl/11996043

…g in ReadFrom This change was applied by hand, as bufio has seen some refactoring since 1.1 was branched. The only difference between this and the original patch is the offset of the change, and s/flush/Flush/. ««« CL 11801043 / 3ffbc06b4874 bufio: check buffer availability before reading in ReadFrom Fixes issue 5947 . R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/11801043 »»» Update #5928 R=golang-dev, r CC=golang-dev https://golang.org/cl/12002043

««« CL 12016043 / 897a42d03643 doc: release notes for go1.1.2 R=golang-dev, go.peter.90, rsc, r CC=golang-dev https://golang.org/cl/12016043 »»» Fixes #5928. R=golang-dev, r, dsymonds CC=golang-dev https://golang.org/cl/12835043

adg added fixed labels Aug 13, 2013

adg self-assigned this Aug 13, 2013

golang locked and limited conversation to collaborators Jun 24, 2016

gopherbot added the FrozenDueToAge label Jun 24, 2016

rsc unassigned adg Jun 22, 2022

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

apply go 1.1.2 patches to release-branch.go1 #5928

apply go 1.1.2 patches to release-branch.go1 #5928

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

rsc commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 23, 2013

rsc commented Jul 25, 2013

rsc commented Jul 25, 2013

adg commented Jul 25, 2013

adg commented Jul 26, 2013

adg commented Jul 28, 2013

adg commented Jul 29, 2013

adg commented Jul 29, 2013

adg commented Jul 29, 2013

adg commented Aug 13, 2013

apply go 1.1.2 patches to release-branch.go1 #5928

apply go 1.1.2 patches to release-branch.go1 #5928

Comments

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 22, 2013

rsc commented Jul 22, 2013

adg commented Jul 22, 2013

adg commented Jul 23, 2013

rsc commented Jul 25, 2013

rsc commented Jul 25, 2013

adg commented Jul 25, 2013

adg commented Jul 26, 2013

adg commented Jul 28, 2013

adg commented Jul 29, 2013

adg commented Jul 29, 2013

adg commented Jul 29, 2013

adg commented Aug 13, 2013