Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build,x/pkgsite: enable tests of x/pkgsite in build.golang.org #59347

Open
hyangah opened this issue Mar 31, 2023 · 3 comments
Open

x/build,x/pkgsite: enable tests of x/pkgsite in build.golang.org #59347

hyangah opened this issue Mar 31, 2023 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 31, 2023

cmd/pkgsite works for go documentation browsing on users machines and replaces the traditional godoc.

Include x/pkgsite to build.golang.org and enable relevant tests in platforms users will use to run cmd/pkgsite.

@bcmills bcmills added this to the Unreleased milestone Mar 31, 2023
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 31, 2023
@findleyr
Copy link
Contributor

findleyr commented Apr 6, 2023

CC @golang/release

Should this issue be moved to x/build?

@bcmills
Copy link
Member

bcmills commented Apr 6, 2023

There are probably two parts: (1) configure x/build to run the tests for the repo, and (2) fix any tests that are discovered to be already failing. Step (1) is x/build, but step (2) is x/pkgsite.

@bcmills bcmills changed the title x/pkgsite: enable tests in build.golang.org x/build,x/pkgsite: enable tests of x/pkgsite in build.golang.org Apr 6, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 6, 2023
@findleyr findleyr modified the milestones: Unreleased, pkgsite/later Apr 6, 2023
@dmitshur
Copy link
Contributor

dmitshur commented May 9, 2023

@hyangah Would you like us to help with the x/build part of this issue? Otherwise most of the work here is to ensure x/pkgsite tests will be passing after a builder is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
Status: Planned
Development

No branches or pull requests

5 participants