Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go list fails with submodules which have test-only dependencies [1.20 backport] #60698

Closed
gopherbot opened this issue Jun 8, 2023 · 3 comments
Closed

cmd/go: go list fails with submodules which have test-only dependencies [1.20 backport] #60698

gopherbot opened this issue Jun 8, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Milestone
Go1.20.6

Comments

@gopherbot
Copy link

@bcmills requested issue #60667 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.19 and 1.20. This is a regression introduced in a previous patch release.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 8, 2023
@gopherbot gopherbot mentioned this issue Jun 8, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.6 milestone Jun 8, 2023
@dmitshur dmitshur added the GoCommand cmd/go label Jun 8, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/502016 mentions this issue: [release-branch.go1.20] cmd/go: omit checksums for go.mod files needed for go version lines more often in pre-1.21 modules

@bcmills bcmills added release-blocker CherryPickApproved Used during the release process for point releases labels Jun 12, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 12, 2023

Approving as a fix for a regression in the previous minor release.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2023
@gopherbot
Copy link
Author

Closed by merging 8b3acef to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Jun 13, 2023
@prattmic
[release-branch.go1.20] cmd/go: omit checksums for go.mod files neede…
8b3acef 
…d for go version lines more often in pre-1.21 modules

This updates the logic from CL 489075 to avoid trying to save extra
sums if they aren't already expected to be present
and cfg.BuildMod != "mod" (as in the case of "go list -m -u all" with
a go.mod file that specifies go < 1.21).

Fixes #60698.
Updates #60667.
Updates #56222.

Change-Id: Ied6ed3e80a62f9cd9a328b43a415a42d14481056
Reviewed-on: https://go-review.googlesource.com/c/go/+/502016
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
@bcmills bcmills mentioned this issue Jun 27, 2023
Closed
@galargh galargh mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Projects
None yet
Milestone
Go1.20.6
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot