Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: TestMarkers/diagnostics/addgowork.txt #61006

Closed
findleyr opened this issue Jun 26, 2023 · 2 comments
Closed

x/tools/gopls: TestMarkers/diagnostics/addgowork.txt #61006

findleyr opened this issue Jun 26, 2023 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

Splitting this failure off from #60584.

This looks like a race, perhaps related to orphaned file reloading. I'll skip this test for now.

--- FAIL: TestMarkers (59.95s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (0.51s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)
@findleyr findleyr added this to the gopls/v0.12.5 milestone Jun 26, 2023
@findleyr findleyr self-assigned this Jun 26, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 26, 2023
@findleyr findleyr modified the milestones: gopls/v0.12.5, gopls/v0.13.0 Jul 13, 2023
@adonovan adonovan added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 31, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.14.1 Oct 9, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.2, gopls/v0.15.0 Nov 14, 2023
@gopherbot
Copy link

Change https://go.dev/cl/555755 mentions this issue: gopls/internal/test/marker: update skip comment for addgowork.txt

@findleyr findleyr mentioned this issue Jan 12, 2024
Closed
@findleyr
Copy link
Contributor Author

Preemptively closing: the test is skipped.

All of this has been rewritten, and with zero config gopls this test is irrelevant.

gopherbot pushed a commit to golang/tools that referenced this issue Jan 17, 2024
@findleyr
gopls/internal/test/marker: update skip comment for addgowork.txt
d2200d1 
The orphaned file and critical error logic has been rewritten, and we no
longer diagnose broken workspaces in this way, because they are no
longer broken due to zero-config gopls.

Fixes golang/go#61006

Change-Id: I7e532c1ecf11b5151ff03103bb19806caaeec565
Reviewed-on: https://go-review.googlesource.com/c/tools/+/555755
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr