log/slog: change XXXCtx function names to XXXContext

[jba]

For consistency with the rest of the standard library, the names of InfoCtx and related functions should be changed to InfoContext, etc.

[rsc]

Not sure how we missed this.

% grep 'Ctx(' *
go1.21.txt:pkg log/slog, func DebugCtx(context.Context, string, ...interface{}) #56345
go1.21.txt:pkg log/slog, func ErrorCtx(context.Context, string, ...interface{}) #56345
go1.21.txt:pkg log/slog, func InfoCtx(context.Context, string, ...interface{}) #56345
go1.21.txt:pkg log/slog, func WarnCtx(context.Context, string, ...interface{}) #56345
go1.21.txt:pkg log/slog, method (*Logger) DebugCtx(context.Context, string, ...interface{}) #56345
go1.21.txt:pkg log/slog, method (*Logger) ErrorCtx(context.Context, string, ...interface{}) #56345
go1.21.txt:pkg log/slog, method (*Logger) InfoCtx(context.Context, string, ...interface{}) #56345
go1.21.txt:pkg log/slog, method (*Logger) WarnCtx(context.Context, string, ...interface{}) #56345
% grep 'Context(' *
go1.1.txt:pkg text/template, method (Template) ErrorContext(parse.Node) (string, string)
go1.1.txt:pkg text/template/parse, method (*Tree) ErrorContext(Node) (string, string)
go1.13.txt:pkg net/http, func NewRequestWithContext(context.Context, string, string, io.Reader) (*Request, error)
go1.15.txt:pkg crypto/tls, method (*Dialer) DialContext(context.Context, string, string) (net.Conn, error)
go1.16.txt:pkg os/signal, func NotifyContext(context.Context, ...os.Signal) (context.Context, context.CancelFunc)
go1.17.txt:pkg crypto/tls, method (*CertificateRequestInfo) Context() context.Context
go1.17.txt:pkg crypto/tls, method (*ClientHelloInfo) Context() context.Context
go1.17.txt:pkg crypto/tls, method (*Conn) HandshakeContext(context.Context) error
go1.18.txt:pkg go/types, func NewContext() *Context
go1.7.txt:pkg net, method (*Dialer) DialContext(context.Context, string, string) (Conn, error)
go1.7.txt:pkg net/http, method (*Request) Context() context.Context
go1.7.txt:pkg net/http, method (*Request) WithContext(context.Context) *Request
go1.7.txt:pkg os/exec, func CommandContext(context.Context, string, ...string) *Cmd
go1.8.txt:pkg database/sql/driver, type ConnPrepareContext interface, PrepareContext(context.Context, string) (Stmt, error)
go1.8.txt:pkg database/sql/driver, type ExecerContext interface, ExecContext(context.Context, string, []NamedValue) (Result, error)
go1.8.txt:pkg database/sql/driver, type QueryerContext interface, QueryContext(context.Context, string, []NamedValue) (Rows, error)
go1.8.txt:pkg database/sql/driver, type StmtExecContext interface, ExecContext(context.Context, []NamedValue) (Result, error)
go1.8.txt:pkg database/sql/driver, type StmtQueryContext interface, QueryContext(context.Context, []NamedValue) (Rows, error)
go1.8.txt:pkg database/sql, method (*DB) ExecContext(context.Context, string, ...interface{}) (Result, error)
go1.8.txt:pkg database/sql, method (*DB) PingContext(context.Context) error
go1.8.txt:pkg database/sql, method (*DB) PrepareContext(context.Context, string) (*Stmt, error)
go1.8.txt:pkg database/sql, method (*DB) QueryContext(context.Context, string, ...interface{}) (*Rows, error)
go1.8.txt:pkg database/sql, method (*DB) QueryRowContext(context.Context, string, ...interface{}) *Row
go1.8.txt:pkg database/sql, method (*Stmt) ExecContext(context.Context, ...interface{}) (Result, error)
go1.8.txt:pkg database/sql, method (*Stmt) QueryContext(context.Context, ...interface{}) (*Rows, error)
go1.8.txt:pkg database/sql, method (*Stmt) QueryRowContext(context.Context, ...interface{}) *Row
go1.8.txt:pkg database/sql, method (*Tx) ExecContext(context.Context, string, ...interface{}) (Result, error)
go1.8.txt:pkg database/sql, method (*Tx) PrepareContext(context.Context, string) (*Stmt, error)
go1.8.txt:pkg database/sql, method (*Tx) QueryContext(context.Context, string, ...interface{}) (*Rows, error)
go1.8.txt:pkg database/sql, method (*Tx) QueryRowContext(context.Context, string, ...interface{}) *Row
go1.8.txt:pkg database/sql, method (*Tx) StmtContext(context.Context, *Stmt) *Stmt
go1.9.txt:pkg database/sql, method (*Conn) ExecContext(context.Context, string, ...interface{}) (Result, error)
go1.9.txt:pkg database/sql, method (*Conn) PingContext(context.Context) error
go1.9.txt:pkg database/sql, method (*Conn) PrepareContext(context.Context, string) (*Stmt, error)
go1.9.txt:pkg database/sql, method (*Conn) QueryContext(context.Context, string, ...interface{}) (*Rows, error)
go1.9.txt:pkg database/sql, method (*Conn) QueryRowContext(context.Context, string, ...interface{}) *Row
go1.txt:pkg regexp/syntax, func EmptyOpContext(int32, int32) EmptyOp
go1.txt:pkg syscall (windows-386), func CertCreateCertificateContext(uint32, *uint8, uint32) (*CertContext, error)
go1.txt:pkg syscall (windows-386), func CertFreeCertificateContext(*CertContext) error
go1.txt:pkg syscall (windows-386), func CryptAcquireContext(*Handle, *uint16, *uint16, uint32, uint32) error
go1.txt:pkg syscall (windows-386), func CryptReleaseContext(Handle, uint32) error
go1.txt:pkg syscall (windows-amd64), func CertCreateCertificateContext(uint32, *uint8, uint32) (*CertContext, error)
go1.txt:pkg syscall (windows-amd64), func CertFreeCertificateContext(*CertContext) error
go1.txt:pkg syscall (windows-amd64), func CryptAcquireContext(*Handle, *uint16, *uint16, uint32, uint32) error
go1.txt:pkg syscall (windows-amd64), func CryptReleaseContext(Handle, uint32) error
% 

Seems reasonable, and worth doing before the next release candidate. OK to submit before this proposal is accepted.

[gopherbot]

Change https://go.dev/cl/508195 mentions this issue: log/slog: change XXXCtx functions to XXXContext

[gopherbot]

Change https://go.dev/cl/508215 mentions this issue: slog: rename XXXCtx to XXXContext

[AndrewHarrisSPU]

#56345 (comment) mentioned readability, just want to double-check that this is preferred:

log.InfoContext(ctx, "msg", "key", val)

over:

log.Log(ctx, slog.LevelInfo, "msg", "key", val)

[jba]

Either one is fine.
I think InfoContext is easier to read: it's clearer that it's at info level.
You need Log to use a level other than the four named ones.
But if a team wants to use Log for everything, that seems fine to me.

[gopherbot]

Change https://go.dev/cl/509099 mentions this issue: all: update vendored dependencies

[rsc]

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group