cmd/go: go.env modifications during bootstrap makes tests fail

[alexsaezm]

What version of Go are you using (go version)?

$ go version
go version go1.20.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GOARCH="amd64"
GOOS="linux"

What did you do?

Using go1.21rc3, modify the go.env file in the root folder to different values.

What did you expect to see?

No failure

What did you see instead?

vcs-test.golang.org rerouted to http://127.0.0.1:41523
https://vcs-test.golang.org rerouted to https://127.0.0.1:43845
go test proxy running at GOPROXY=http://127.0.0.1:42835/mod
--- FAIL: TestScript (0.15s)
    --- FAIL: TestScript/mod_sumdb_golang (0.04s)
        script_test.go:132: 2023-07-14T16:32:19Z
        script_test.go:134: $WORK=/tmp/cmd-go-test-3903922678/tmpdir168532271/mod_sumdb_golang759362308
        script_test.go:156:
            # Test default GOPROXY and GOSUMDB (0.040s)
            > env GOPROXY=
            > env GOSUMDB=
            > go env GOPROXY
            [stdout]
            direct
            > stdout '^https://proxy.golang.org,direct$'
        script_test.go:156: FAIL: testdata/script/mod_sumdb_golang.txt:5: stdout ^https://proxy.golang.org,direc
t$: no match for `(?m)^https://proxy.golang.org,direct$` in stdout
FAIL
FAIL    cmd/go  45.416s

This used to happend to in rc2 as far as I know: #57179 (comment)

[cherrymui]

Using go1.21rc3, modify the go.env file in the root folder to different values.

@alexsaezm could you clarify the exact commands you run? Modify the go.env file, then run all.bash?
And does this reproduce with Go 1.20? Thanks.

Perhaps setting GOPROXY and GOSUMDB to empty just makes them to use the value in the go.env file. The test probably needs some mechanism to ignore go.env file.

cc @bcmills @matloob

[bcmills]

Using go1.21rc3, modify the go.env file in the root folder to different values.

Which values specifically?

[gopherbot]

Change https://go.dev/cl/509637 mentions this issue: cmd/go: fix tests with GOPROXY=direct in go.env

[alexsaezm]

I modified the go.env file in the root of the project like this:

$ cat go.env
# This file contains the initial defaults for go command configuration.
# Values set by 'go env -w' and written to the user's go/env file override these.
# The environment overrides everything else.

# Use the Go module mirror and checksum database by default.
# See https://proxy.golang.org for details.
GOPROXY=direct
GOSUMDB=off

# Automatically download newer toolchains as directed by go.mod files.
# See https://go.dev/doc/toolchain for details.
GOTOOLCHAIN=auto

And then, I ran ./all.bash.

To clarify, this doesn't happen in 1.20 because there is no go.env file.

[bcmills]

@alexsaezm, https://go.dev/cl/509637 should fix this at HEAD; can you please build at commit 229cde5 or later and confirm?

[alexsaezm]

@alexsaezm, https://go.dev/cl/509637 should fix this at HEAD; can you please build at commit 229cde5 or later and confirm?

It works. Thank you!

Regarding the commit message about the builders: just for the record, Fedora's Go package is built with the go.env modified so in case of any error, I'll report it. (Not a substitute of a builder by any means, because it's not integrated at all with Go upstream systems and includes other patches but, just to let you know)