Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: various build failures due to panic in go/types.(*StdSizes).Sizeof #62103

Closed
findleyr opened this issue Aug 17, 2023 · 6 comments
Closed

all: various build failures due to panic in go/types.(*StdSizes).Sizeof #62103

findleyr opened this issue Aug 17, 2023 · 6 comments

Comments

@findleyr
Copy link
Contributor

It looks like https://go.dev/cl/506856 broke a number of builders:

CC @cuonglm @griesemer
@cuonglm
Copy link
Member

cuonglm commented Aug 17, 2023

https://go-review.googlesource.com/c/go/+/520435 fixed longtest builders.

x/vuln and x/exp probably need to update golang.org/x/tools, too.

@gopherbot
Copy link

Change https://go.dev/cl/520555 mentions this issue: cmd: go get golang.org/x/tools@74c255b

@gopherbot
Copy link

Change https://go.dev/cl/520575 mentions this issue: all: go get golang.org/x/tools@74c255b

gopherbot pushed a commit to golang/vuln that referenced this issue Aug 17, 2023
@cuonglm @gopherbot
all: go get golang.org/x/tools@74c255b
da4b74a 
go get golang.org/x/tools@74c255b # CL 519295
go mod tidy

Pulling in the fix for unnecessary dependency on *types.StdSizes, which
is non guaranteed behavior.

Updates golang/go#62103

Change-Id: I351e98f59dafc728b6821330b897a0457f4127d1
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/520555
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot pushed a commit to golang/exp that referenced this issue Aug 17, 2023
@cuonglm @gopherbot
all: go get golang.org/x/tools@74c255b
d852ddb 
go get golang.org/x/tools@74c255b # CL 519295
go mod tidy

Pulling in the fix for unnecessary dependency on *types.StdSizes, which
is non guaranteed behavior.

Updates golang/go#62103

Change-Id: Ib9a4095d7fcacac5d377f0364aafc8709bb31033
Reviewed-on: https://go-review.googlesource.com/c/exp/+/520575
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@cuonglm
Copy link
Member

cuonglm commented Aug 17, 2023

@findleyr Both CLs are submitted.

Should we close this now, or leave it open for others builders failure observation if any?

@findleyr
Copy link
Contributor Author

Thanks for the quick fix! I'll close this once the builds pass.

@findleyr
Copy link
Contributor Author

...which appears to have happened.

@timothy-king timothy-king mentioned this issue Nov 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cuonglm @gopherbot @findleyr