crypto/internal/boring: noescape and nocallback cgo directives result in suspected miscompilation

[stapelberg]

#!watchflakes
default <- builder == "linux-arm64-boringcrypto" && date > "2023-10-22" && date < "2023-10-26"

We identified https://go.googlesource.com/go/+/e46e861 to be the culprit for breaking many Google-internal tests (internal bug reference: b/307728752).

I’m sending a revert for now, but this should be investigated in more detail.

[bcmills]

Marked as release-blocker for Go 1.22 because the noescape and nocallback cgo directives are new in Go 1.22. If they result in miscompilation or a buggy interaction with the runtime, that feature should be rolled back so that it isn't released in a broken state.

(attn @golang/compiler, @golang/runtime)

[gopherbot]

Change https://go.dev/cl/537598 mentions this issue: Revert "crypto/internal/boring: use noescape and nocallback cgo directives"

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- builder == "linux-arm64-boringcrypto" && date > "2023-10-22" && date < "2023-10-26"

2023-10-23 20:47 linux-arm64-boringcrypto go@f9c54f9c net/http.TestMaxBytesHandler (log)

--- FAIL: TestMaxBytesHandler (0.08s)
    --- FAIL: TestMaxBytesHandler/max_size_1000000_request_size_1000000 (0.02s)
        --- FAIL: TestMaxBytesHandler/max_size_1000000_request_size_1000000/h2 (0.01s)
            serve_test.go:6713: set RST avoidance delay to 1ms
panic: boringcrypto: EVP_AEAD_CTX_seal failed [recovered]
	panic: boringcrypto: EVP_AEAD_CTX_seal failed

goroutine 1485 [running]:
panic({0x51bd20?, 0x67a530?})
	/tmp/workdir/go/src/runtime/panic.go:772 +0x140 fp=0x40005ff0e0 sp=0x40005ff030 pc=0x1306a0
...
net/http_test.run[...].func1()
	/tmp/workdir/go/src/net/http/clientserver_test.go:90 +0x104 fp=0x40005fff60 sp=0x40005fff10 pc=0x4c0b34
testing.tRunner(0x40007d6820, 0x400034c030)
	/tmp/workdir/go/src/testing/testing.go:1593 +0xe8 fp=0x40005fffb0 sp=0x40005fff60 pc=0x1fb198
testing.(*T).Run.gowrap1()
	/tmp/workdir/go/src/testing/testing.go:1646 +0x2c fp=0x40005fffd0 sp=0x40005fffb0 pc=0x1fbf7c
runtime.goexit({})
	/tmp/workdir/go/src/runtime/asm_arm64.s:1197 +0x4 fp=0x40005fffd0 sp=0x40005fffd0 pc=0x1676e4
created by testing.(*T).Run in goroutine 1145
	/tmp/workdir/go/src/testing/testing.go:1646 +0x318

— watchflakes