Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/trace/v2: failures on Windows #64061

Closed
mknyszek opened this issue Nov 10, 2023 · 4 comments
Closed

internal/trace/v2: failures on Windows #64061

mknyszek opened this issue Nov 10, 2023 · 4 comments
Assignees
@mknyszek
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.22

Comments

@mknyszek
Copy link
Contributor 

#!watchflakes
default <- pkg == "internal/trace/v2" && test ~ `TestTrace`

There are two kinds of failures on Windows I've seen so far. One is "per-M streams out of order" and the other is "expected a proc but didn't have one". I understand what's happening in both, just have to fix them.
@mknyszek mknyszek self-assigned this Nov 10, 2023
@mknyszek mknyszek added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 10, 2023
@mknyszek mknyszek modified the milestones: Backlog, Go1.22 Nov 10, 2023
@mknyszek mknyszek added release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) NeedsFix The path to resolution is known, but the work has not been done. labels Nov 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/541197 mentions this issue: internal/trace/v2: disable TestTrace* tests on Windows for now

gopherbot pushed a commit that referenced this issue Nov 10, 2023
@mknyszek @gopherbot
internal/trace/v2: disable TestTrace* tests on Windows for now
505dff4 
There are a couple known issues here. Disable the tests for now so it's
not blocking anyone.

For #64061.

Change-Id: Iaaa9007b93ea78739cb7d2b59b2a1715de29d72b
Reviewed-on: https://go-review.googlesource.com/c/go/+/541197
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
@mknyszek
Copy link
Contributor Author

Removing Soon since I landed a temporary mitigation.

@mknyszek mknyszek removed the Soon This needs to be done soon. (regressions, serious bugs, outages) label Nov 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/541695 mentions this issue: internal/trace/v2: don't enforce batch order on Ms

@gopherbot
Copy link

Change https://go.dev/cl/541696 mentions this issue: internal/trace/v2: resolve syscall parsing ambiguity

gopherbot pushed a commit that referenced this issue Nov 14, 2023
@mknyszek @gopherbot
internal/trace/v2: don't enforce batch order on Ms
e8298c0 
Currently the trace parser enforces that the timestamps for a series of
a batches on the same M come in order. We cannot actually assume this in
general because we don't trust timestamps. The source of truth on the
batch order is the order in which they were emitted. If that's wrong, it
should quickly become evident in the trace.

For #60773.
For #64061.

Change-Id: I7d5a407c9568dd1ce0b79d51b2b538ed6072b26d
Reviewed-on: https://go-review.googlesource.com/c/go/+/541695
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
@mknyszek mknyszek mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknyszek mknyszek

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot