New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/x509: TestIssue51759 consistently failing on gotip-darwin-amd64_10.15
LUCI builder
#64677
Comments
Bah, sorry. I remember looking into this to try to find the right macOS API and then completely dropping it on the ground. Will send a CL. |
Change https://go.dev/cl/549195 mentions this issue: |
@gopherbot Please backport to 1.20 and 1.21. This test failure applies on those release branches as well. |
Backport issue(s) opened: #65379 (for 1.20), #65380 (for 1.21). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
Change https://go.dev/cl/559516 mentions this issue: |
Change https://go.dev/cl/559517 mentions this issue: |
Fixes the gating of TestIssue51759 by shelling out to sw_vers to check what version of macOS we are on. For #64677 Fixes #65379 Change-Id: I5eef4fa39e5449e7b2aa73864625c3abf002aef8 Reviewed-on: https://go-review.googlesource.com/c/go/+/549195 Reviewed-by: Bryan Mills <bcmills@google.com> Auto-Submit: Roland Shoemaker <roland@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit 400e24a) Reviewed-on: https://go-review.googlesource.com/c/go/+/559516 Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Fixes the gating of TestIssue51759 by shelling out to sw_vers to check what version of macOS we are on. For #64677 Fixes #65380 Change-Id: I5eef4fa39e5449e7b2aa73864625c3abf002aef8 Reviewed-on: https://go-review.googlesource.com/c/go/+/549195 Reviewed-by: Bryan Mills <bcmills@google.com> Auto-Submit: Roland Shoemaker <roland@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit 400e24a) Reviewed-on: https://go-review.googlesource.com/c/go/+/559517 Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Fixes the gating of TestIssue51759 by shelling out to sw_vers to check what version of macOS we are on. Fixes golang#64677 Change-Id: I5eef4fa39e5449e7b2aa73864625c3abf002aef8 Reviewed-on: https://go-review.googlesource.com/c/go/+/549195 Reviewed-by: Bryan Mills <bcmills@google.com> Auto-Submit: Roland Shoemaker <roland@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Go version
100651b
What operating system and processor architecture are you using (
go env
)?BOTO_CONFIG=/opt/s/w/ir/x/a/gsutil-bbagent/.boto BUILDBUCKET_EXPERIMENTAL=FALSE CIPD_ARCHITECTURE=amd64 CIPD_CACHE_DIR=/opt/s/cipd_cache/cache CIPD_PROTOCOL=v2 CLOUDSDK_CONFIG=/opt/s/w/ir/x/a/gcloud-bbagent DOCKER_CONFIG=/opt/s/w/ir/x/a/docker-cfg-bbagent DOCKER_TMPDIR=/opt/s/w/ir/x/a/docker-tmp-bbagent FIREBASE_TOKEN=ignored-non-empty-value FIREBASE_TOKEN_URL=http://127.0.0.1:54955 GCE_METADATA_HOST=127.0.0.1:54954 GCE_METADATA_IP=127.0.0.1:54954 GCE_METADATA_ROOT=127.0.0.1:54954 GIT_TERMINAL_PROMPT=0 GOARCH=amd64 GOBIN= GOCACHE=/opt/s/w/ir/x/w/gocache GOHOSTARCH=amd64 GOHOSTOS=darwin GOOS=darwin GOPATH=/opt/s/w/ir/x/w/gopath GOROOT= GOROOT_BOOTSTRAP=/opt/s/w/ir/cache/tools/go_bootstrap GOTOOLCHAIN=local GO_BUILDER_NAME=gotip-darwin-amd64_10.15 HOME=/Users/chrome-bot INFRA_GIT_WRAPPER_HOME=/opt/s/w/ir/x/a/git-home-bbagent ISOLATED_RESOLVED_PACKAGE_VERSIONS_FILE=/opt/s/w/itbjdy5xx0/cipd_info.json LOGDOG_COORDINATOR_HOST=logs.chromium.org LOGDOG_NAMESPACE=u/step/10/u LOGDOG_STREAM_PREFIX=buildbucket/cr-buildbucket/8761961540549152833 LOGDOG_STREAM_PROJECT=golang LOGDOG_STREAM_SERVER_PATH=unix:/opt/s/w/ir/x/ld/sock.2886421883 LOGNAME=chrome-bot LUCI_CONTEXT=/opt/s/w/itbjdy5xx0/luci_context.2539259758 MAC_CHROMIUM_TMPDIR=/opt/s/w/ir/x/t NO_GCE_CHECK=False PATH=/opt/s/w/ir/x/w/goroot/bin:/opt/s/w/ir/cache/tools/bin:/opt/s/w/ir/bbagent_utility_packages:/opt/s/w/ir/bbagent_utility_packages/bin:/opt/s/w/ir/cipd:/opt/s/w/ir/cipd/bin:/opt/s/w/ir/cipd_bin_packages:/opt/s/w/ir/cipd_bin_packages/bin:/opt/s/w/ir/cipd_bin_packages/cpython3:/opt/s/w/ir/cipd_bin_packages/cpython3/bin:/opt/s/cipd_cache/bin:/opt/infra-tools:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/git/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PYTHONCOERCECLOCALE=0 PYTHONNOUSERSITE=1 SHELL=/bin/zsh SHIVAS_BINARY=/opt/shivas/shivas SHIVAS_NAMESPACE=browser SHIVAS_RO_CRED=/opt/creds/service_accounts/service-account-machine-db-ro.json SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.XVLMuZv0Wo/Listeners SWARMING_BOT_ID=mac-327-h526 SWARMING_EXTERNAL_BOT_SETUP=1 SWARMING_HEADLESS=1 SWARMING_SERVER=https://chromium-swarm.appspot.com SWARMING_TASK_ID=6674266fa4adc311 TEMP=/opt/s/w/ir/x/t TEMPDIR=/opt/s/w/ir/x/t TMP=/opt/s/w/ir/x/t TMPDIR=/opt/s/w/ir/x/t USER=chrome-bot VPYTHON_VIRTUALENV_ROOT=/opt/s/w/ir/cache/vpython XPC_FLAGS=0x0 XPC_SERVICE_NAME=org.swarm.bot __CF_USER_TEXT_ENCODING=0x1F6:0x0:0x0 PWD=/opt/s/w/ir/x/w/goroot/src /opt/s/w/ir/cache/tools/bin/rdb stream -var goos:darwin -var goarch:amd64 -var host_goos:darwin -var host_goarch:amd64 -var builder:gotip-darwin-amd64_10.15 -var go_branch:master -tag bootstrap_version:1.20.6 -tag xcode_version:11e503a -- /opt/s/w/ir/cache/tools/bin/result_adapter go -- /opt/s/w/ir/x/w/goroot/bin/go tool dist test -json
What did you do?
View post-commit test results:
https://ci.chromium.org/ui/p/golang/builders/ci/gotip-darwin-amd64_10.15/b8761961540549152833/test-results?sortby=&groupby=
What did you expect to see?
All tests passing.
What did you see instead?
This was supposed to have been fixed in https://go.dev/cl/472496 (for #58812), but — as I noted in a post-commit comment on that change — the test-skip added in that change was too narrowly targeted: to the Go project's builders, rather than to the affected versions of macOS.
(attn @rolandshoemaker @golang/release)
The text was updated successfully, but these errors were encountered: