Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: nil pointer dereference in Alias.Underlying() [1.22 backport] #65728

Closed
gopherbot opened this issue Feb 15, 2024 · 2 comments
Closed

go/types: nil pointer dereference in Alias.Underlying() [1.22 backport] #65728

gopherbot opened this issue Feb 15, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.22.1

Comments

@gopherbot
Copy link
Contributor

@findleyr requested issue #65455 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider this for backport to 1.22, it's a deterministic panic with a simple fix.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 15, 2024
@gopherbot gopherbot mentioned this issue Feb 15, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.1 milestone Feb 15, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/564356 mentions this issue: [release-branch.go1.22] go/types, types2: ensure that Alias.actual is set in NewAlias

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Feb 21, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 21, 2024
gopherbot pushed a commit that referenced this issue Feb 27, 2024
@findleyr @cagedmantis
[release-branch.go1.22] go/types, types2: ensure that Alias.actual is…
3b71998 
… set in NewAlias

Types returned by the go/types API must be immutable (or at least
concurrency safe), but NewAlias returned an alias without actual set.

Ensure that actual is set by unaliasing. Also make some superficial
simplifications to unalias, and avoid indirection where unnecessary.

Fixes #65728

Change-Id: Ic9a020da5accf9032056a924b65c9e9e08cb2e0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/560915
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Robert Griesemer <gri@google.com>
(cherry picked from commit 10a6564)
Reviewed-on: https://go-review.googlesource.com/c/go/+/564356
@gopherbot
Copy link
Contributor Author

Closed by merging 3b71998 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@findleyr @bradfitz
[release-branch.go1.22] go/types, types2: ensure that Alias.actual is…
cdd42c6 
… set in NewAlias

Types returned by the go/types API must be immutable (or at least
concurrency safe), but NewAlias returned an alias without actual set.

Ensure that actual is set by unaliasing. Also make some superficial
simplifications to unalias, and avoid indirection where unnecessary.

Fixes golang#65728

Change-Id: Ic9a020da5accf9032056a924b65c9e9e08cb2e0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/560915
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Robert Griesemer <gri@google.com>
(cherry picked from commit 10a6564)
Reviewed-on: https://go-review.googlesource.com/c/go/+/564356
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@findleyr @romaindoumenc
[release-branch.go1.22] go/types, types2: ensure that Alias.actual is…
7ecb055 
… set in NewAlias

Types returned by the go/types API must be immutable (or at least
concurrency safe), but NewAlias returned an alias without actual set.

Ensure that actual is set by unaliasing. Also make some superficial
simplifications to unalias, and avoid indirection where unnecessary.

Fixes golang#65728

Change-Id: Ic9a020da5accf9032056a924b65c9e9e08cb2e0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/560915
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Robert Griesemer <gri@google.com>
(cherry picked from commit 10a6564)
Reviewed-on: https://go-review.googlesource.com/c/go/+/564356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
2 participants
@prattmic @gopherbot