Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/xml: Wrong indication in encoding/xml Unmarshal doc (chardata) #6631

Closed
gopherbot opened this Issue Oct 21, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@gopherbot
Copy link

gopherbot commented Oct 21, 2013

by viriketo:

On go 1.1.2:

The Unmarshal doc says:
  * If the XML element contains character data, that data is
     accumulated in the first struct field that has tag "chardata".

It should say ",chardata". "chardata" alone doesn't work.
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented Oct 21, 2013

Comment 1:

Labels changed: added priority-soon, go1.2maybe, removed priority-triage.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Oct 29, 2013

Comment 2:

This issue was closed by revision 2e984c2.

Status changed to Fixed.

@adg

This comment has been minimized.

Copy link
Contributor

adg commented Nov 1, 2013

Comment 3:

This issue was closed by revision 4ca5466d4896.

@gopherbot gopherbot added fixed labels Nov 1, 2013

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015

@rsc rsc removed the go1.2maybe label Apr 14, 2015

adg added a commit that referenced this issue May 11, 2015

[release-branch.go1.2] encoding/xml: fix doc comment
««« CL 19300046 / 5ac568b9d67b
encoding/xml: fix doc comment

The tag is ",chardata" not "chardata".

Fixes #6631.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/19300046
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20060045

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.