Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: Go 1.22.x failed to be bootstrapped from 386 to ppc64le [1.22 backport] #67018

Closed
gopherbot opened this issue Apr 24, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone

Comments

@gopherbot
Copy link
Contributor

@pmur requested issue #66955 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider a backport to go 1.22. This prevents crosscompiling ppc64x code on 32 bit hosts.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 24, 2024
@gopherbot gopherbot added this to the Go1.22.3 milestone Apr 24, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/581455 mentions this issue: [release-branch.go1.22] cmd/internal/obj/ppc64: fix incorrect int to int64 conversion when checking MOVD opcodes

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Apr 24, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 24, 2024
@dmitshur dmitshur changed the title Go 1.22.x failed to be bootstrapped from 386 to ppc64le [1.22 backport] cmd/compile: Go 1.22.x failed to be bootstrapped from 386 to ppc64le [1.22 backport] Apr 24, 2024
@gopherbot
Copy link
Contributor Author

Closed by merging 12c1177 to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue Apr 26, 2024
…int64 conversion when checking MOVD opcodes

A type conversion from int to int64 was done in the wrong place causing
some MOVD $const, Rx operations to be incorrectly transformed on 32 bit
hosts cross-compiling for ppc64x.

Fixes #67018

Change-Id: I023ba267a8dac6d6bd22f8146c0d9d2d473bc5c1
Reviewed-on: https://go-review.googlesource.com/c/go/+/580796
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Joedian Reid <joedian@google.com>
Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/581455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Development

No branches or pull requests

2 participants