Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/trace: remove the v1 tracer code #67367

Closed
cagedmantis opened this issue May 14, 2024 · 5 comments
Closed

cmd/trace: remove the v1 tracer code #67367

cagedmantis opened this issue May 14, 2024 · 5 comments
Assignees
@cagedmantis
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.23

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented May 14, 2024 •
edited

The Execution tracer has been overhauled. The remnants of the old execution tracer should be removed.
@cagedmantis cagedmantis added NeedsFix The path to resolution is known, but the work has not been done. compiler/runtime Issues related to the Go compiler and/or runtime. labels May 14, 2024
@cagedmantis cagedmantis added this to the Go1.23 milestone May 14, 2024
@cagedmantis cagedmantis self-assigned this May 14, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/584537 mentions this issue: internal/trace: remove remnanats of v1 tracer

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/584536 mentions this issue: cmd/trace: collapse v2 directory into trace

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/584538 mentions this issue: internal/trace: move v2 tracer into trace directory

gopherbot pushed a commit that referenced this issue May 17, 2024
@cagedmantis
cmd/trace: collapse v2 directory into trace
01ad44b 
This change removes the old trace code and replaces it with the new tracer.
It does the following:
- Moves the contents of the v2 directory into the parent trace directory.
- Combines the old tracer main file with the new main file.
- Replaces any existing files with the corresponding v2 files.
- Removes any unused files.

Updates #67367

Change-Id: I2237920e13588258a2442b639d562cf7f8a8e944
Reviewed-on: https://go-review.googlesource.com/c/go/+/584536
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
gopherbot pushed a commit that referenced this issue May 17, 2024
@cagedmantis
internal/trace: remove remnanats of v1 tracer
664088b 
This change removes unused parts of the v1 tracer in preperation of
the move of the v2 tracer into the trace package.

Updates #67367

Change-Id: I3e53a8afdef72dc90c2d5b514380d1077d284bc7
Reviewed-on: https://go-review.googlesource.com/c/go/+/584537
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit that referenced this issue May 17, 2024
@cagedmantis
internal/trace: move v2 tracer into trace directory
5890b02 
This change moves the v2 tracer into the trace directory.

Updates #67367

Change-Id: I3657b4227002cb00fdf29c797434800ea796715e
Reviewed-on: https://go-review.googlesource.com/c/go/+/584538
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@aclements
Copy link
Member

Is there anything more to be done here?

@cagedmantis
Copy link
Contributor Author

i believe this is done. I was just waiting for the post-submits to run before closing the issue. But I will close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagedmantis cagedmantis

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Compiler / Runtime
Status: Done
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@cagedmantis @aclements @gopherbot