Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: release gopls@v0.16.0-pre.1 prior to 1.23rc1 #67616

Closed
findleyr opened this issue May 23, 2024 · 4 comments
Closed

x/tools/gopls: release gopls@v0.16.0-pre.1 prior to 1.23rc1 #67616

findleyr opened this issue May 23, 2024 · 4 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented May 23, 2024

This issue exists to block the release of go1.23rc1 on the existence of a gopls@v0.16.0-pre.1 release.

gopls@master has support for 1.23 features that does not yet exist in gopls@latest. Notably:

  • Support for range-over-func (including SSA)
  • Support for gotypesalias=1
  • Support for the new API of runtime.SetCrashOutput (currently, gopls@latest doesn't built with go1.23 due to an API change)
  • (soon) support for godebug directives in go.mod and go.work files

Ideally, we'd like to release gopls@v0.16.0 prior to go1.23rc1, so that gopls users can experiment with the new language features. At the very least, we should have a gopls prerelease with this support before the Go release candidate.

See the gopls/v0.16.0 milestone for the current status of this release.

CC @dmitshur @joedian

@findleyr findleyr added this to the Go1.23 milestone May 23, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 23, 2024
@findleyr findleyr self-assigned this May 23, 2024
@adonovan
Copy link
Member

I notice that x/tools/internal/stdlib doesn't include go1.23 symbols yet, because the various api/next/*.txt files haven't yet been consolidated into go1.23.txt. What causes that to happen? (Paging @mknyszek author of https://go.dev/cl/544555.)

@dmitshur
Copy link
Contributor

dmitshur commented May 31, 2024

The timing of api files being merged isn't exactly the same as in past releases because they're also involved in the test for improved release notes (#64169). I'm working on that for this cycle, so feel free to ping me instead of Michael.

The task that updates x/tools/internal/stdlib nominally happens during the go1.N.0 (final) release, not RC 1:

https://cs.opensource.google/go/x/build/+/master:internal/relui/workflows.go;l=487-491;drc=ef977b72d670c8f407e16e2b411ce7b95dd80474

@adonovan
Copy link
Member

Wait, you already have a release automation task to update x/tools/internal/stdlib? Wow, you are on it!

@findleyr
Copy link
Contributor Author

-pre.1 is released, so this is done.

Given the updated RC timing, we hope to actually release v0.16.0 prior to the RC, but this need not block the RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

4 participants