x/build: update the rc1 announcement template to mention min gopls version and telemetry #67618
Comments
findleyr
changed the title
|
If we do release gopls@v0.16.0 before the rc1, we may not need to mention gopls, since many editors auto-update. However, we do regularly see users confused because they forgot to reinstall their tools. We could perhaps suggest reinstalling tools as part of the release announcement 🤔. |
dmitshur
added
the
NeedsFix
|
Change https://go.dev/cl/592199 mentions this issue: |
|
I'm not yet closing this issue with the above CL, because depending on whether we land gopls@v0.16.0, we may want to also suggest using gopls@v0.16.0-pre.1. If we are able to release gopls prior to the RC, no such addition is necessary, since most users are auto-updated to the latest gopls version. |
An easy way for users to help validate release candidates is by opting in to telemetry. Suggest this in RC release announcements. For golang/go#67618 Change-Id: I2eace20a18addbb32566de07155c1f4cd0bc309a Reviewed-on: https://go-review.googlesource.com/c/build/+/592199 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Robert Findley <rfindley@google.com>
|
This is marked as a release blocker, is open, is not marked okay-after-RC1, and the scheduled cut for 1.23RC1 is roughly 24 hours from now. Where do we stand on this? |
|
Change https://go.dev/cl/593055 mentions this issue: |
|
Change https://go.dev/cl/593057 mentions this issue: |
The Markdown parser used here emits separate AST nodes for regular and fenced code blocks. Despite that partial support for the former was started in the initial CL 411575, it appears incomplete. Code blocks weren't exercised by the existing announcement templates, and there wasn't coverage for them in the TestMarkdownToText sample input either, which is why things stayed as they were for this long. They're about to be used more actively, so unify their handling, and render them as plain text without additional indentation. This seems to work out better in this context. For golang/go#67618. Change-Id: Ia1b3cfeb56716624916535c51b45c49bb078101e Co-authored-by: Robert Findley <rfindley@google.com> Reviewed-on: https://go-review.googlesource.com/c/build/+/593057 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
For the go1.23rc1 release announcement, we want to:
@dmitshur suggests that the easiest way to do this may be to modify the announcement template at
https://cs.opensource.google/go/x/build/+/master:internal/task/template/announce-rc.md;drc=59c99abb1cb61040972a82e0e4ba4f61a95ac34e
For this release, we could guard these additions with
{{if eq .Version "go1.23rc1"}}, but in fact we may want to include both of these features in all future release candidate announcements. It seems like it may always be worthwhile to inform users which gopls version is required to work with new language features, and to ask them to enable telemetry so that we can collect more information about the release candidate.CC @dmitshur @joedian @rsc
The text was updated successfully, but these errors were encountered: