Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: update the rc1 announcement template to mention min gopls version and telemetry #67618

Closed
findleyr opened this issue May 23, 2024 · 7 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@findleyr
Copy link
Contributor

For the go1.23rc1 release announcement, we want to:

  • Highlight the version of gopls required to use new language features (in this case, this will be gopls@v0.16.0 or gopls@v0.16.0-pre.1).
  • Ask users to opt-in to telemetry to help improve our releases.

@dmitshur suggests that the easiest way to do this may be to modify the announcement template at
https://cs.opensource.google/go/x/build/+/master:internal/task/template/announce-rc.md;drc=59c99abb1cb61040972a82e0e4ba4f61a95ac34e

For this release, we could guard these additions with {{if eq .Version "go1.23rc1"}}, but in fact we may want to include both of these features in all future release candidate announcements. It seems like it may always be worthwhile to inform users which gopls version is required to work with new language features, and to ask them to enable telemetry so that we can collect more information about the release candidate.

CC @dmitshur @joedian @rsc

@findleyr findleyr added this to the Go1.23 milestone May 23, 2024
@findleyr findleyr self-assigned this May 23, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 23, 2024
@findleyr findleyr changed the title x/build: update release announcement template to mention gopls and telemetry x/build: update the rc1 announcement template to mention min gopls version and telemetry May 23, 2024
@findleyr
Copy link
Contributor Author

If we do release gopls@v0.16.0 before the rc1, we may not need to mention gopls, since many editors auto-update. However, we do regularly see users confused because they forgot to reinstall their tools. We could perhaps suggest reinstalling tools as part of the release announcement 🤔.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 12, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592199 mentions this issue: internal/task: suggest enabling telemetry in RC announcements

@findleyr
Copy link
Contributor Author

I'm not yet closing this issue with the above CL, because depending on whether we land gopls@v0.16.0, we may want to also suggest using gopls@v0.16.0-pre.1. If we are able to release gopls prior to the RC, no such addition is necessary, since most users are auto-updated to the latest gopls version.

gopherbot pushed a commit to golang/build that referenced this issue Jun 13, 2024
An easy way for users to help validate release candidates is by opting
in to telemetry. Suggest this in RC release announcements.

For golang/go#67618

Change-Id: I2eace20a18addbb32566de07155c1f4cd0bc309a
Reviewed-on: https://go-review.googlesource.com/c/build/+/592199
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Robert Findley <rfindley@google.com>
@dr2chase
Copy link
Contributor

This is marked as a release blocker, is open, is not marked okay-after-RC1, and the scheduled cut for 1.23RC1 is roughly 24 hours from now. Where do we stand on this?

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/593055 mentions this issue: internal/task: update the go1.23rc1 announcement to mention gopls

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/593057 mentions this issue: internal/task: unify handling of regular and fenced code blocks

gopherbot pushed a commit to golang/build that referenced this issue Jun 17, 2024
The Markdown parser used here emits separate AST nodes for regular and
fenced code blocks. Despite that partial support for the former was
started in the initial CL 411575, it appears incomplete. Code blocks
weren't exercised by the existing announcement templates, and there
wasn't coverage for them in the TestMarkdownToText sample input either,
which is why things stayed as they were for this long.

They're about to be used more actively, so unify their handling, and
render them as plain text without additional indentation. This seems
to work out better in this context.

For golang/go#67618.

Change-Id: Ia1b3cfeb56716624916535c51b45c49bb078101e
Co-authored-by: Robert Findley <rfindley@google.com>
Reviewed-on: https://go-review.googlesource.com/c/build/+/593057
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/593679 mentions this issue: internal/task/template: remove special gopls instructions for go1.23rc1

gopherbot pushed a commit to golang/build that referenced this issue Jun 20, 2024
Now that gopls@v0.16.0 is released, users do not need special
instructions to install the gopls prerelease.

Updates golang/go#67618

Change-Id: I18dae3f3f2eaf99efda9d555d7e227ef10b5a98c
Reviewed-on: https://go-review.googlesource.com/c/build/+/593679
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Status: Done
Development

No branches or pull requests

4 participants