Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: SIGSEGV after performing clone(CLONE_PARENT) via C constructor prior to runtime start [1.22 backport] #67650

Closed
gopherbot opened this issue May 25, 2024 · 2 comments
Closed

runtime: SIGSEGV after performing clone(CLONE_PARENT) via C constructor prior to runtime start [1.22 backport] #67650

gopherbot opened this issue May 25, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.4

Comments

@gopherbot
Copy link
Contributor

@kolyshkin requested issue #65625 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider this for backport to 1.22, it’s a major regression for runc (it stopped working completely).
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 25, 2024
@gopherbot gopherbot mentioned this issue May 25, 2024
Open
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 25, 2024
@gopherbot gopherbot added this to the Go1.22.4 milestone May 25, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/587979 mentions this issue: [release-branch.go1.22] runtime: x_cgo_getstackbound: initialize pthread attr

@kolyshkin kolyshkin mentioned this issue May 25, 2024
Closed
@mdempsky mdempsky added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 29, 2024
@humblec humblec mentioned this issue May 29, 2024
Open
45 tasks
gopherbot pushed a commit that referenced this issue May 29, 2024
@kolyshkin @gopherbot
[release-branch.go1.22] runtime: x_cgo_getstackbound: initialize pthr…
95389d3 
…ead attr

In glibc versions older than 2.32 (before commit 4721f95),
pthread_getattr_np does not always initialize the `attr` argument,
and when it fails, it results in a NULL pointer dereference in
pthread_attr_destroy down the road.

This is the simplest way to avoid this, and an alternative to CL 585019.

Fixes #67650.

Change-Id: If490fd37020b03eb084ebbdbf9ae0248916426d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/587919
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/587979
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Commit-Queue: Matthew Dempsky <mdempsky@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 95389d3 to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.4
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot