net/http: test fails with "Too many goroutines running" after benchmarks

[jbardin]

What does 'go version' print?

go1.4beta1

What steps reproduce the problem?

from net/http run:

    $ go test -run NONE -bench ClientServerParallel

What happened?

Test failure with:

Too many goroutines running after net/http test(s).
1 instances of:
net/http.(*persistConn).writeLoop(0xc2085738c0)
    /home/pretzel/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/pretzel/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc208601ef0)
    /home/pretzel/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
[...]

Please provide any additional information below.

On linux/amd64 the goroutines all seem to be in *persistConn.writeLoop, while on
darwin/amd64 they all over the place in various goroutines.

[ianlancetaylor]

Comment 1:

Happens for me too on GNU/Linux.
> go test -run NONE -bench ClientServerParallel net/http
PASS
BenchmarkClientServerParallel4     20000         89747 ns/op        4600 B/op         62 allocs/op
BenchmarkClientServerParallel64    20000         90859 ns/op        4427 B/op         62
allocs/op
BenchmarkClientServerParallelTLS4      20000        105482 ns/op        4780 B/op         78
allocs/op
BenchmarkClientServerParallelTLS64     10000        145782 ns/op        5652 B/op         95
allocs/op
Too many goroutines running after net/http test(s).
1 instances of:
net/http.(*persistConn).writeLoop(0xc2085c36b0)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/iant/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc20862c4d0)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/iant/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc208060580)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/iant/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc208060dc0)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/iant/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc208061a20)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/iant/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc2085c3290)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/iant/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc20862cfd0)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /home/iant/go/src/net/http/transport.go:661 +0xcbc1 instances of:
net/http.(*persistConn).writeLoop(0xc208060630)
    /home/iant/go/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
etc.

Labels changed: added repo-main, release-go1.4.

Status changed to Accepted.

[bradfitz]

Comment 3:

Owner changed to @bradfitz.

Status changed to Started.

[gopherbot]

Comment 4:

CL https://golang.org/cl/170210043 mentions this issue.

[bradfitz]

Comment 5:

This issue was closed by revision cf105e2.

Status changed to Fixed.