Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builders: windows version assumptions for builder should be documented #9397

Closed
jeffallen opened this issue Dec 19, 2014 · 5 comments
Closed

Comments

@jeffallen
Copy link
Contributor

It would be helpful if this document: http://golang.org/s/windowsbuilderhowto ag

stated clearly what Windows is expected to be able to run a Go builder. It looks like wstrap.exe is a 64-bit binary, so it needs to be Windows 64-bit. But windows 7? or 8?

Thanks.

@alexbrainman
Copy link
Member

@jeffallen,

I didn't write / don't use winstrap program. Brad and Andrew did / do. And I don't have write access to http://golang.org/s/windowsbuilderhowto

But, I think, winstrap is not very usable for anyone, but its authors. They use it to convert new Windows PC into fully functional builder with minimum time and effort. And for documenting the process. I don't see why anyone else would want to do that.

It looks like wstrap.exe is a 64-bit binary, so it needs to be Windows 64-bit.

You're correct. But Brad and Andrew use Windows 64-bit PCs only, so it works for them.

But windows 7? or 8?

It should work for any supported (by Go) Windows version. Starting from Windows XP and up.

Closing as nothing to do.

Alex

@jeffallen
Copy link
Contributor Author

It is useful and usable for me when I want to test changes on Windows. ☺
I'll be sending a pull req for some things that didn't work for me and I
fixed. Unless you tell "no, pull reqs not accepted".
On Dec 20, 2014 2:27 AM, "alexbrainman" notifications@github.com wrote:

@jeffallen https://github.com/jeffallen,

I didn't write / don't use winstrap program. Brad and Andrew did / do. And
I don't have write access to http://golang.org/s/windowsbuilderhowto

But, I think, winstrap is not very usable for anyone, but its authors.
They use it to convert new Windows PC into fully functional builder with
minimum time and effort. And for documenting the process. I don't see why
anyone else would want to do that.

It looks like wstrap.exe is a 64-bit binary, so it needs to be Windows
64-bit.

You're correct. But Brad and Andrew use Windows 64-bit PCs only, so it
works for them.

But windows 7? or 8?

It should work for any supported (by Go) Windows version. Starting from
Windows XP and up.

Closing as nothing to do.

Alex


Reply to this email directly or view it on GitHub
#9397 (comment).

@minux minux assigned bradfitz and unassigned alexbrainman Dec 23, 2014
@minux
Copy link
Member

minux commented Dec 23, 2014

Will let @bradfitz decide to take pull request or not for golang/winstrap.

@minux minux reopened this Dec 23, 2014
@mikioh mikioh changed the title windows version assumptions for builder should be documented builders: windows version assumptions for builder should be documented Jan 4, 2015
@mikioh mikioh added the builder label Jan 4, 2015
@bradfitz
Copy link
Contributor

bradfitz commented Jan 5, 2015

Feel free to send pull requests to Winstrap. I should move it to Gerrit at some point, though.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc
Copy link
Contributor

rsc commented Apr 14, 2015

Winstrap is gone now.

@rsc rsc closed this as completed Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants