Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytes: re-slice buffer to its previous length after call to grow() #25436

Closed
wants to merge 4 commits into from

Conversation

forfuncsake
Copy link
Contributor

Fixes #25435

The added test fails without the re-slice and passes with it.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 17, 2018
@gopherbot
Copy link

This PR (HEAD: bf408a4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: e49d42d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2: Code-Review-2

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Dave Russell:

Patch Set 2:

(2 comments)

Thanks for the review


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Dave Russell:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 11f1921) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 454ddad) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 4: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=04b77217


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/113495.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/113495 has been merged.

@gopherbot gopherbot closed this May 29, 2018
gopherbot pushed a commit that referenced this pull request May 29, 2018
Fixes #25435

The added test fails without the re-slice and passes with it.

Change-Id: I5ebc2a737285eb116ecc5938d8bf49050652830f
GitHub-Last-Rev: 454ddad
GitHub-Pull-Request: #25436
Reviewed-on: https://go-review.googlesource.com/113495
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants