New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bytes: re-slice buffer to its previous length after call to grow() #25436
Conversation
This PR (HEAD: bf408a4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
This PR (HEAD: e49d42d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 2: Code-Review-2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
Message from Dave Russell: Patch Set 2: (2 comments) Thanks for the review Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
Message from Ian Lance Taylor: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
Message from Dave Russell: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
This PR (HEAD: 11f1921) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 454ddad) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/113495 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=04b77217 Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/113495. |
This PR is being closed because golang.org/cl/113495 has been merged. |
Fixes #25435 The added test fails without the re-slice and passes with it. Change-Id: I5ebc2a737285eb116ecc5938d8bf49050652830f GitHub-Last-Rev: 454ddad GitHub-Pull-Request: #25436 Reviewed-on: https://go-review.googlesource.com/113495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Fixes #25435
The added test fails without the re-slice and passes with it.