Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: golint var and function name fixes #27974

Closed
wants to merge 6 commits into from
Closed

net/http: golint var and function name fixes #27974

wants to merge 6 commits into from

Conversation

esell
Copy link
Contributor

@esell esell commented Oct 2, 2018

Various fixes for linting issues found by golint in the net/http package

Updates #21779

Currently there is no example for http.Post in the
documentation. This adds an example.

Change-Id: I4ef827381cb8fc601dcd6fd73755b097be1905d2
Resolves `client.go:217:39: error strings should not be capitalized or
end with punctuation or a newline` detected by `golint`

Updates #21779

Change-Id: I59767dd7b09d2f12a8f72d79c103dbb0ba908d5d
Resolves `cookie.go:33:2: struct field HttpOnly should be HTTPOnly` detected by `golint`

Updates #21779

Change-Id: I4813344021791e92727bd7db020291608e7290cf
Resolves various var naming issues detected by `golint`

Updates #21779

Change-Id: Idbfdcd3ecc15d12df97e7a506a295654c1d626cc
Resolves `request.go:1321:19: method wantsHttp10KeepAlive should be wantsHTTP10KeepAlive` detected by `golint`

Change-Id: I6908a46f393118d212069b61e7f79fe7e47c892b
Resolves various var naming issues detected by `golint`

Updates #21779

Change-Id: I70d0cf1356dd25b74a290c9a01602b97a247a348
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 2, 2018
@gopherbot
Copy link

This PR (HEAD: eb144bf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/139097 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gerrit User 5065:

Patch Set 1: Code-Review-2

(1 comment)

This breaks the API promise and makes a bunch of unnecessary changes to internal stuff.

I don't see anything in here we need.


Please don’t reply on this GitHub thread. Visit golang.org/cl/139097.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 28970:

Patch Set 1:

Yikes, ok. Is it proper procedure to close the PR out on Github then?


Please don’t reply on this GitHub thread. Visit golang.org/cl/139097.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5065:

Patch Set 1:

Yeah, you can just close the PR on GitHub.


Please don’t reply on this GitHub thread. Visit golang.org/cl/139097.
After addressing review feedback, remember to publish your drafts!

@esell esell closed this Oct 2, 2018
@bradfitz bradfitz reopened this Oct 3, 2018
@bradfitz bradfitz closed this Oct 3, 2018
@gopherbot
Copy link

This PR is being closed because golang.org/cl/139097 has been abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants