New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mime: encode CTL and non-US-ASCII characters in FormatMediaType #29328

Closed

andrius4669 wants to merge 1 commit into golang:master from andrius4669:formatmediatype-encode

Contributor

andrius4669 commented Dec 18, 2018 •

edited by bradfitz

Encodes non-WSP CTL and non-US-ASCII UTF-8 characters using syntax specified in RFC 2231.

Fixes #7668
Fixes #9624


          mime: encode CTL and non-US-ASCII characters in FormatMediaType

9c77146

Encodes non-WSP CTL and non-US-ASCII UTF-8 characters using syntax specified in RFC 2231.
Fixes #7668 and #9624.

googlebot added the cla: yes label

gopherbot commented Dec 18, 2018

This PR (HEAD: 9c77146) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/154760 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

andrius4669 mentioned this pull request

mime: FormatMediaType doesn't allow to create Content-Disposition #9624

Closed

gopherbot commented Mar 2, 2019

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 2, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ba5c7e0c

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 2, 2019

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on linux-386:
See https://storage.googleapis.com/go-build-log/ba5c7e0c/linux-386_8b7dba25.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 2, 2019

Message from Brad Fitzpatrick:

Patch Set 2: Patch Set 1 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 2, 2019

Message from Brad Fitzpatrick:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 2, 2019

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3ad1054f

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 2, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

7 of 19 TryBots failed:
Failed on linux-386: https://storage.googleapis.com/go-build-log/ba5c7e0c/linux-386_8b7dba25.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/ba5c7e0c/openbsd-amd64-64_30bd60f4.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/ba5c7e0c/linux-amd64_64afe186.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/ba5c7e0c/freebsd-amd64-12_0_fee8d177.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/ba5c7e0c/windows-386-2008_1c2cdaa9.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/ba5c7e0c/windows-amd64-2016_9102ffd9.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/ba5c7e0c/linux-amd64-race_69f3a8d2.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 2, 2019

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 26, 2019

Message from Agniva De Sarker:

Patch Set 2:

Brad ?

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          mime: encode CTL and non-US-ASCII characters in FormatMediaType

0ac4ea7

Encodes non-WSP CTL and non-US-ASCII UTF-8 characters using syntax specified in RFC 2231.

Fixes #7668
Fixes #9624

Change-Id: I433f167c5bdd84a7f811ac0410b08b10790e0d9f
GitHub-Last-Rev: 9c77146
GitHub-Pull-Request: #29328
Reviewed-on: https://go-review.googlesource.com/c/go/+/154760
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

gopherbot commented May 23, 2019

Message from Brad Fitzpatrick:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/154760.
After addressing review feedback, remember to publish your drafts!

gopherbot commented May 23, 2019

This PR is being closed because golang.org/cl/154760 has been merged.

gopherbot closed this

patkujawa-wf commented Jan 14, 2020 •

edited

Naive question: How can I tell what version of Go this will be / is released in?

Contributor Author

andrius4669 commented Apr 9, 2020

1.13.
you can see all the tags in 0ac4ea7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment