cmd/go: remove note about GOCACHE=off in docs #29681
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 820694f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/157517 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
|
Message from Elias Naur: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
|
Message from Bryan C. Mills: Patch Set 1: Code-Review+1 Please run src/cmd/go/mkalldocs.sh and amend the results into this change. Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
bradfitz
changed the title
thaJeztah
force-pushed
the
fix_GOCACHE_docs
branch
from
820694f
to
1e2a81d
Compare
|
This PR (HEAD: 1e2a81d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/157517 to see it. Tip: You can toggle comments from me using the |
|
Message from Sebastiaan van Stijn: Patch Set 2:
Whoops, thanks: updated 👍 Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
Setting GOCACHE=off is no longer allowed in upcoming releases of Go. Fixes golang#29680
thaJeztah
force-pushed
the
fix_GOCACHE_docs
branch
from
1e2a81d
to
31e904f
Compare
|
Message from Bryan C. Mills: Patch Set 3: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
|
This PR (HEAD: 31e904f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/157517 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=4d1f20fe Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
|
Message from Sebastiaan van Stijn: Patch Set 4: (3 comments) Think it's all done :-) Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
|
Message from Elias Naur: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
|
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=d8cd0c76 Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
|
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/157517. |
This patch removes mention of GOCACHE=off from the help/docs. It is no longer supported in Go 1.12, per the release notes. Fixes #29680 Change-Id: I53ab15a62743f2e55ae1d8aa50629b1bf1ae32ad GitHub-Last-Rev: 31e904f GitHub-Pull-Request: #29681 Reviewed-on: https://go-review.googlesource.com/c/157517 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
|
This PR is being closed because golang.org/cl/157517 has been merged. |
This patch removes mention of GOCACHE=off from the help/docs.
It is no longer supported in Go 1.12, per the release notes.
Fixes #29680