Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: "only supported as of -lang=go1.13" error is misleading [1.13 backport] #33761

Closed
gopherbot opened this issue Aug 21, 2019 · 3 comments
Closed

cmd/compile: "only supported as of -lang=go1.13" error is misleading [1.13 backport] #33761

gopherbot opened this issue Aug 21, 2019 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #33753 to be considered for backport to the next 1.13 minor release.

@gopherbot please open backport to 1.13

This is an unnecessarily confusing error message for people who want to try the new 1.13 language features, so when we fix it I think we should backport the fix to the 1.13 release series.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 21, 2019
@gopherbot gopherbot mentioned this issue Aug 21, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 2, 2019
@julieqiu
Copy link
Member

julieqiu commented Sep 2, 2019

Approved according to our policy at https://github.com/golang/go/wiki, since this is a documentation fix.

@julieqiu julieqiu added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 2, 2019
@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/201480 mentions this issue: [release-branch.go1.13] cmd/compile: better error message for language version errors

@gopherbot
Copy link
Author

Closed by merging 985804b to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Oct 16, 2019
@griesemer @andybons
[release-branch.go1.13] cmd/compile: better error message for languag…
985804b 
…e version errors

Fixes #33761.
Updates #33753.
Updates #31747.

Change-Id: Icc42b23405ead4f7f17b0ffa3611405454b6b271
Reviewed-on: https://go-review.googlesource.com/c/go/+/198491
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 27fc32f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/201480
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
4 participants
@bcmills @julieqiu @gopherbot @katiehockman