New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cancel function which can cancel a context due to an error #34761
Conversation
Sometimes, we run mutilple go routines in a context, if one go routine failed due to an error, we want to cancel the context and record the error in it. So I added a function called WithErrorCancel function which returns both CancelFunc and ErrorCancelFunc. CancelFunc is the same as the function which is returned by WithCancel, ErrorCancelFunc is used to cancel a context with an error.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: b19f271) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/199505 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/199505. |
Message from Agniva De Sarker: Patch Set 1: Code-Review-2 Hi Xiaoran, This CL adds new public API. We follow the proposal process (https://golang.org/s/proposal) which needs to be discussed and approved first, and then you can send the change. I would request you to file a github issue first outlining why you need this change and why this needs to be in the standard library. Once accepted, we can work on the review. Till then, I will mark it as -2 to prevent accidental submission. Please don’t reply on this GitHub thread. Visit golang.org/cl/199505. |
Have created a issue for this pr: |
Closing per comments on https://go-review.googlesource.com/c/go/+/199505 |
Sometimes, we run mutilple go routines in a context, if one go routine
failed due to an error, we want to cancel the context and record the
error in it. So I added a function called WithErrorCancel function which
returns both CancelFunc and ErrorCancelFunc. CancelFunc is the same as
the function which is returned by WithCancel, ErrorCancelFunc is used to
cancel a context with an error.