New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path/filepath: allow EvalSymlinks to work on UNC share roots on Windows #42096

Closed

kevpar wants to merge 1 commit into golang:master from kevpar:fix-evalsymlinks

Contributor

kevpar commented Oct 20, 2020

Fixes #42079

Previously, EvalSymlinks returned an error when called with the root of
a UNC share (e.g. \server\share). This was due to Windows's
FindFirstFile function not supporting a share root path.

To resolve this, now return early from toNorm in the case where the path
after the volume name is empty. Skipping the later path component
resolution shouldn't have any negative impact in this case, as if the
path is empty, there aren't any path components to resolve anyways.

The test case uses the localhost admin share (c$), as it should be
present in most situations. This allows testing without setting up an
external file share. However, this fix applies to all UNC share root
paths.


          path/filepath: allow EvalSymlinks to work on UNC share roots on Windows

bd3db2c

Fixes golang#42079

Previously, EvalSymlinks returned an error when called with the root of
a UNC share (e.g. \\server\share). This was due to Windows's
FindFirstFile function not supporting a share root path.

To resolve this, now return early from toNorm in the case where the path
after the volume name is empty. Skipping the later path component
resolution shouldn't have any negative impact in this case, as if the
path is empty, there aren't any path components to resolve anyways.

The test case uses the localhost admin share (c$), as it should be
present in most situations. This allows testing without setting up an
external file share. However, this fix applies to all UNC share root
paths.

google-cla bot added the cla: yes label

gopherbot commented Oct 20, 2020

This PR (HEAD: bd3db2c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Oct 20, 2020

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263917.
After addressing review feedback, remember to publish your drafts!

kevpar mentioned this pull request

path/filepath: EvalSymlinks fails on Windows when passed a UNC share root path #42079

Closed

gopherbot commented Oct 25, 2020

Message from Alex Brainman:

Patch Set 1: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/263917.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 25, 2020

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=9a1eb90b

Please don’t reply on this GitHub thread. Visit golang.org/cl/263917.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 25, 2020

Message from Go Bot:

Patch Set 1:

Build is still in progress...
This change failed on (x/tools) linux-amd64:
See https://storage.googleapis.com/go-build-log/9a1eb90b/linux-amd64_61a3bfdc.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263917.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 25, 2020

Message from Go Bot:

Patch Set 1: TryBot-Result-1

1 of 20 TryBots failed:
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/9a1eb90b/linux-amd64_61a3bfdc.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/263917.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 25, 2020

Message from Alex Brainman:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/263917.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Oct 25, 2020

Message from Alex Brainman:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/263917.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          path/filepath: allow EvalSymlinks to work on UNC share roots on Windows

Fixes #42079

Previously, EvalSymlinks returned an error when called with the root of
a UNC share (e.g. \\server\share). This was due to Windows's
FindFirstFile function not supporting a share root path.

To resolve this, now return early from toNorm in the case where the path
after the volume name is empty. Skipping the later path component
resolution shouldn't have any negative impact in this case, as if the
path is empty, there aren't any path components to resolve anyways.

The test case uses the localhost admin share (c$), as it should be
present in most situations. This allows testing without setting up an
external file share. However, this fix applies to all UNC share root
paths.

Change-Id: I05035bd86be93662d7bea34fab4b75fc8e918206
GitHub-Last-Rev: bd3db2c
GitHub-Pull-Request: #42096
Reviewed-on: https://go-review.googlesource.com/c/go/+/263917
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Giovanni Bajo <rasky@develer.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

gopherbot commented Oct 25, 2020

This PR is being closed because golang.org/cl/263917 has been merged.

gopherbot closed this

marosset mentioned this pull request

fixing issue where SMB share paths cannot resolve with CRI-containerD on Windows kubernetes/kubernetes#96396

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment