Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: fix non-script staleness checks interacting badly with GOFLAGS #43155

Closed
wants to merge 1 commit into from
Closed

cmd/go: fix non-script staleness checks interacting badly with GOFLAGS #43155

wants to merge 1 commit into from

Conversation

programmer04
Copy link
Contributor

Fixes #43012.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 12, 2020
@gopherbot
Copy link

This PR (HEAD: b56c088) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/277453 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Jay Conrod:

Patch Set 1: Run-TryBot+1 Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/277453.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=235191ad

Please don’t reply on this GitHub thread. Visit golang.org/cl/277453.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/277453.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Bryan C. Mills:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/277453.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 11, 2021
@programmer04
cmd/go: fix non-script staleness checks interacting badly with GOFLAGS
81ea89a 
Fixes #43012.

Change-Id: Idc7a64b53c411e6dadd98521a48e15e664737d42
GitHub-Last-Rev: b56c088
GitHub-Pull-Request: #43155
Reviewed-on: https://go-review.googlesource.com/c/go/+/277453
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/277453 has been merged.

@gopherbot gopherbot closed this Jan 11, 2021
@programmer04 programmer04 deleted the fix-test-GOFLAGS branch January 12, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/go: non-script staleness checks interact badly with GOFLAGS
2 participants
@programmer04 @gopherbot