Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/pem: PEM multiline headers #43580

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pschou
Copy link

@pschou pschou commented Jan 8, 2021

This fixes a TODO. The current reader for PEM files does not properly handle reading or writing in headers that have multiple lines.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 8, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: b61fa9a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/282572 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: bab48b9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/282572 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: a958a4d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/282572 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: d1db37a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/282572 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Paul Schou:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/282572.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants